Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gotify Notifications via Webhook #1561

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Add Gotify Notifications via Webhook #1561

merged 8 commits into from
Jun 24, 2024

Conversation

svenvg93
Copy link
Contributor

πŸ“ƒ Description

As listed in #40 this PR will add support for Gotify

βž• Added

  • Gotify to the Notification page
  • Add Gotify to the settings migration
  • Add notification view

πŸ“· Screenshots

SchermΒ­afbeelding 2024-06-22 om 10 04 19 image

@svenvg93 svenvg93 requested a review from alexjustesen as a code owner June 22, 2024 08:10
@alexjustesen alexjustesen changed the base branch from main to develop-0.21.0 June 24, 2024 21:25
@alexjustesen
Copy link
Owner

Duster got updated in the pipeline but I forgot to bump the package, #1569 fixes that. You can update your branches from develop-0.21.0 to get the latest deps and then run sail composer install.

@alexjustesen alexjustesen added the πŸŽ‰ feature New feature or request label Jun 24, 2024
@alexjustesen alexjustesen changed the title Add Gotify Notifications Add Gotify Notifications via Webhook Jun 24, 2024
@alexjustesen alexjustesen added this to the v0.x.0 (notifications) milestone Jun 24, 2024
@alexjustesen alexjustesen merged commit c40c8d0 into alexjustesen:develop-0.21.0 Jun 24, 2024
1 check passed
@svenvg93 svenvg93 deleted the 40-add-gotify branch June 25, 2024 05:32
@alexjustesen alexjustesen mentioned this pull request Jun 25, 2024
12 tasks
@Retract1822
Copy link

Thank you! I've been waiting for this. When can we expect this to be added into the package release/docker image?

@alexjustesen
Copy link
Owner

Thank you! I've been waiting for this. When can we expect this to be added into the package release/docker image?

Hopefully later this week, @svenvg93 has done a fantastic job adding more notification channels and the bottleneck is my "free" time has been pretty tight lately for open-source projects.

@svenvg93
Copy link
Contributor Author

svenvg93 commented Aug 5, 2024

Thank you! I've been waiting for this. When can we expect this to be added into the package release/docker image?

Hopefully later this week, @svenvg93 has done a fantastic job adding more notification channels and the bottleneck is my "free" time has been pretty tight lately for open-source projects.

Now I just hope it all works as tested ;)

@Retract1822
Copy link

Retract1822 commented Aug 5, 2024

Thank you! I've been waiting for this. When can we expect this to be added into the package release/docker image?

Hopefully later this week, @svenvg93 has done a fantastic job adding more notification channels and the bottleneck is my "free" time has been pretty tight lately for open-source projects.

Thank you! I've been waiting for this. When can we expect this to be added into the package release/docker image?

Hopefully later this week, @svenvg93 has done a fantastic job adding more notification channels and the bottleneck is my "free" time has been pretty tight lately for open-source projects.

Now I just hope it all works as tested ;)

I realise how much time this must take from your personal lives so wanted you to know that it's very much appreciated and thank you for the great product!

alexjustesen added a commit that referenced this pull request Aug 8, 2024
* Add Placeholder text for notifications (#1570)

first_commit

* Add Gotify Notifications via Webhook (#1561)

* first_commit

* Ready!

* Add_placeholder

* change url

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Support for Slack Notifications via Webhook (#1522)

* First Commit

* Fix lint

* add_url_placeholder

* Fix the liniting

* Add HealthCheck.io Notifications via Webhooks (#1567)

* first_commit

* linting

* add_descrip_for_threshold

* Change name

* add_url_placeholder

* fix_linting

* Add Pushover Notifications via Webhooks (#1574)

* add_pushover

* add_placeholder

* Linting

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add ntfy Notifications via Webhooks (#1579)

* first_push

* Fix_json_payload

* Add_auth_option

* fix lint

* fix packet_loss_%

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Ookla URL to the notification (#1615)

* first commit

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Fix notifications layouts (#1639)

first commit

---------

Co-authored-by: Sven van Ginkel <[email protected]>
alexjustesen added a commit that referenced this pull request Aug 8, 2024
* Develop v0.21.0 (additional notification channels) (#1647)

* Add Placeholder text for notifications (#1570)

first_commit

* Add Gotify Notifications via Webhook (#1561)

* first_commit

* Ready!

* Add_placeholder

* change url

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Support for Slack Notifications via Webhook (#1522)

* First Commit

* Fix lint

* add_url_placeholder

* Fix the liniting

* Add HealthCheck.io Notifications via Webhooks (#1567)

* first_commit

* linting

* add_descrip_for_threshold

* Change name

* add_url_placeholder

* fix_linting

* Add Pushover Notifications via Webhooks (#1574)

* add_pushover

* add_placeholder

* Linting

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add ntfy Notifications via Webhooks (#1579)

* first_push

* Fix_json_payload

* Add_auth_option

* fix lint

* fix packet_loss_%

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Ookla URL to the notification (#1615)

* first commit

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Fix notifications layouts (#1639)

first commit

---------

Co-authored-by: Sven van Ginkel <[email protected]>

* updated npm dependencies

---------

Co-authored-by: Sven van Ginkel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸŽ‰ feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants