Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Discord Webhook Functionality #1196

Merged
merged 8 commits into from
Feb 22, 2024

Conversation

jonezy35
Copy link
Contributor

πŸ“ƒ Description

This PR adds functionality to support Discord webhook notifications. Closes Discord channel in #40 and satisfies user requests in #754

πŸͺ΅ Changelog

βž• Added

  • Discord option in UI for notifications
  • Discord listener for speedtest notifications on all runs
  • Discord listener for speedtest notifications on thresholds being met

✏️ Changed

N/A

πŸ”§ Fixed

N/A

πŸ—‘οΈ Removed

N/A

πŸ“· Screenshots

discord_speedtest

@alexjustesen alexjustesen mentioned this pull request Feb 20, 2024
12 tasks
@masterwishx
Copy link

@alexjustesen can it be merged now ?

@alexjustesen alexjustesen added the πŸŽ‰ feature New feature or request label Feb 21, 2024
app/Filament/Pages/Settings/NotificationPage.php Outdated Show resolved Hide resolved
app/Listeners/SpeedtestCompletedListener.php Outdated Show resolved Hide resolved
app/Listeners/Threshold/AbsoluteListener.php Show resolved Hide resolved
app/Listeners/Threshold/AbsoluteListener.php Outdated Show resolved Hide resolved
app/Listeners/Threshold/AbsoluteListener.php Outdated Show resolved Hide resolved
@alexjustesen
Copy link
Owner

@jonezy35 nice work! I left some formatting comments and looks like the Linter wants some additional changes.

If you want to lint locally run sail bin duster lint --using=pint -v before committing changes.

@jonezy35
Copy link
Contributor Author

@jonezy35 nice work! I left some formatting comments and looks like the Linter wants some additional changes.

If you want to lint locally run sail bin duster lint --using=pint -v before committing changes.

@alexjustesen all issues should be fixed now. Made the syntax changes you requested and resolved all lint errors locally before committing. Thanks for the local lint syntax

@jonezy35
Copy link
Contributor Author

Might think about adding the lint check to the development guide so in the future those errors can be handled before the PR is opened

@alexjustesen
Copy link
Owner

Good call, I'll do that and review the PR again tonight.

@alexjustesen alexjustesen merged commit 6efa8f4 into alexjustesen:main Feb 22, 2024
2 checks passed
@alexjustesen alexjustesen added this to the v0.x.0 (notifications) milestone Feb 22, 2024
@jonezy35
Copy link
Contributor Author

@alexjustesen thanks! I'm going to start looking into the slack functionality as well now that I have this down. What is the process/ timeline for the docker container to update with the new functionality once a PR is merged?

@alexjustesen
Copy link
Owner

@jonezy35 going to move this chat to a discussion, got some additional thoughts and changes I need to make and don't want to lose it in the PR.

@alexjustesen
Copy link
Owner

Let's chat here: #1220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸŽ‰ feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants