-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Discord Webhook Functionality #1196
Conversation
@alexjustesen can it be merged now ? |
database/migrations/2024_02_19_000000_create_discord_notification_settings.php
Outdated
Show resolved
Hide resolved
@jonezy35 nice work! I left some formatting comments and looks like the Linter wants some additional changes. If you want to lint locally run |
@alexjustesen all issues should be fixed now. Made the syntax changes you requested and resolved all lint errors locally before committing. Thanks for the local lint syntax |
Might think about adding the lint check to the development guide so in the future those errors can be handled before the PR is opened |
Good call, I'll do that and review the PR again tonight. |
@alexjustesen thanks! I'm going to start looking into the slack functionality as well now that I have this down. What is the process/ timeline for the docker container to update with the new functionality once a PR is merged? |
@jonezy35 going to move this chat to a discussion, got some additional thoughts and changes I need to make and don't want to lose it in the PR. |
Let's chat here: #1220 |
π Description
This PR adds functionality to support Discord webhook notifications. Closes Discord channel in #40 and satisfies user requests in #754
πͺ΅ Changelog
β Added
βοΈ Changed
N/A
π§ Fixed
N/A
ποΈ Removed
N/A
π· Screenshots