Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid looking up the default port in is_default_port when no explicit port is set #1168

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 1, 2024

What do these changes do?

Avoid looking up the default port in is_default_port when no explicit port is set

Are there changes in behavior for the user?

no

Related issue number

aio-libs/aiohttp#9366

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.55%. Comparing base (62b52d1) to head (aad487a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
- Coverage   95.56%   95.55%   -0.01%     
==========================================
  Files          30       30              
  Lines        4911     4909       -2     
  Branches      446      446              
==========================================
- Hits         4693     4691       -2     
  Misses        192      192              
  Partials       26       26              
Flag Coverage Δ
CI-GHA 95.51% <100.00%> (-0.01%) ⬇️
MyPy 42.20% <100.00%> (-0.03%) ⬇️
OS-Linux 99.41% <100.00%> (-0.01%) ⬇️
OS-Windows 99.50% <100.00%> (-0.01%) ⬇️
OS-macOS 99.13% <100.00%> (-0.01%) ⬇️
Py-3.10.11 99.02% <100.00%> (-0.01%) ⬇️
Py-3.10.15 99.25% <100.00%> (-0.01%) ⬇️
Py-3.11.10 99.25% <100.00%> (-0.01%) ⬇️
Py-3.11.9 99.02% <100.00%> (-0.01%) ⬇️
Py-3.12.6 99.25% <100.00%> (-0.01%) ⬇️
Py-3.13.0-rc.2 99.25% <100.00%> (-0.01%) ⬇️
Py-3.8.10 98.97% <100.00%> (-0.01%) ⬇️
Py-3.8.18 99.20% <100.00%> (-0.01%) ⬇️
Py-3.9.13 98.97% <100.00%> (-0.01%) ⬇️
Py-3.9.20 99.20% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.11 99.26% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 99.26% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.17 99.29% <100.00%> (-0.01%) ⬇️
VM-macos-latest 99.13% <100.00%> (-0.01%) ⬇️
VM-ubuntu-latest 99.41% <100.00%> (-0.01%) ⬇️
VM-windows-latest 99.50% <100.00%> (-0.01%) ⬇️
pytest 99.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 1, 2024 17:31
@bdraco bdraco merged commit bb3c41f into master Oct 1, 2024
47 of 49 checks passed
@bdraco bdraco deleted the is_default_port branch October 1, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant