Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of converting URL to a string #1170

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 2, 2024

This is effectively the same optimization as done in #1168 for the internal _port_not_default cached property. If port is not already cached, we avoid one property lookup.

@bdraco bdraco changed the title Imporve performance of converting URL to a string Improve performance of converting URL to a string Oct 2, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 2, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (bb3c41f) to head (0ac9ced).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   95.55%   95.56%           
=======================================
  Files          30       30           
  Lines        4909     4917    +8     
  Branches      446      446           
=======================================
+ Hits         4691     4699    +8     
  Misses        192      192           
  Partials       26       26           
Flag Coverage Δ
CI-GHA 95.52% <100.00%> (+<0.01%) ⬆️
MyPy 42.13% <27.27%> (-0.08%) ⬇️
OS-Linux 99.41% <100.00%> (+<0.01%) ⬆️
OS-Windows 99.50% <100.00%> (+<0.01%) ⬆️
OS-macOS 99.13% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 99.03% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 99.26% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 99.26% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 99.03% <100.00%> (+<0.01%) ⬆️
Py-3.12.6 99.26% <100.00%> (+<0.01%) ⬆️
Py-3.13.0-rc.2 99.26% <100.00%> (+<0.01%) ⬆️
Py-3.13.0-rc.3 ?
Py-3.8.10 98.98% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 99.20% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 98.98% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 99.20% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.11 99.26% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 99.26% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.17 99.29% <100.00%> (+<0.01%) ⬆️
VM-macos-latest 99.13% <100.00%> (+<0.01%) ⬆️
VM-ubuntu-latest 99.41% <100.00%> (+<0.01%) ⬆️
VM-windows-latest 99.50% <100.00%> (+<0.01%) ⬆️
pytest 99.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review October 3, 2024 15:44
@bdraco bdraco merged commit 79d53eb into master Oct 3, 2024
47 of 49 checks passed
@bdraco bdraco deleted the port_not_default branch October 3, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant