-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small speed up to update_headers #9366
Conversation
- Avoid checking to see if the port is default if no port is set - Avoid using strip for a single char check
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9366 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 107 107
Lines 34981 34984 +3
Branches 4149 4150 +1
=======================================
+ Hits 34478 34481 +3
Misses 335 335
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 43deadb on top of patchback/backports/3.10/43deadb286df2a05de09d00121ed90811ca232a2/pr-9366 Backporting merged PR #9366 into master
🤖 @patchback |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9382 🤖 @patchback |
(cherry picked from commit 43deadb)
(cherry picked from commit 43deadb)
…9382) Co-authored-by: J. Nick Koston <[email protected]>
What do these changes do?
is_default_port
check which has to work out the default port internally in yarl since if there is no explict port set, it must be the default portEvent if we have to call
is_default_port
,explict_port
will already be cachedAre there changes in behavior for the user?
no
Is it a substantial burden for the maintainers to support this?
no