Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5678/264a441a backport][3.8] Use an SVG logo across the docs #5712

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented May 14, 2021

This is a backport of PR #5678 as merged into master (264a441).

What do these changes do?

This patch switches the png logo with an SVG one.

Are there changes in behavior for the user?

The logo in the docs looks nicer when zoomed in.

Related issue number

Resolves #5677

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

* Update README.rst

#5677

* Update conf.py

* Update conf.py

* Fix html_logo rel path in `conf.py`

* Keep the branch name in the logo URI in README

* Move html logo definition to the intended location

* Add a custom CSS file

* Create logo-adjustments.css

* Drop the unused PNG logo from docs assets

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit 264a441)
@patchback patchback bot requested review from asvetlov and webknjaz as code owners May 14, 2021 22:39
@patchback patchback bot mentioned this pull request May 14, 2021
5 tasks
@webknjaz webknjaz enabled auto-merge (squash) May 14, 2021 22:40
@webknjaz webknjaz disabled auto-merge May 14, 2021 22:40
@webknjaz webknjaz merged commit 09d5b24 into 3.8 May 14, 2021
@webknjaz webknjaz deleted the patchback/backports/3.8/264a441acf7d0d01bf34c3bedbaf05b0e0bb43a6/pr-5678 branch May 14, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants