Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO] Use an SVG logo in the Sphinx docs #5677

Closed
webknjaz opened this issue May 7, 2021 · 0 comments · Fixed by #5678
Closed

[TODO] Use an SVG logo in the Sphinx docs #5677

webknjaz opened this issue May 7, 2021 · 0 comments · Fixed by #5678
Labels
documentation Improvements or additions to documentation enhancement good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/

Comments

@webknjaz
Copy link
Member

webknjaz commented May 7, 2021

🐣 Is your feature request related to a problem? Please describe.

I noticed that the sphinx docs use a non-scalable png file as a logo. It needs to be changed.

💡 Describe the solution you'd like

Use https://github.com/aio-libs/aiohttp/blob/master/docs/aiohttp-plain.svg in sphinx instead.

❓ Describe alternatives you've considered

N/A

📋 Additional context

N/A
@webknjaz webknjaz added enhancement good first issue Good for newcomers documentation Improvements or additions to documentation Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/ labels May 7, 2021
@himanshu007-creator himanshu007-creator mentioned this issue May 7, 2021
Merged
5 tasks
@webknjaz webknjaz mentioned this issue May 14, 2021
Closed
webknjaz added a commit that referenced this issue May 14, 2021
@himanshu007-creator @webknjaz
Use an SVG logo across the docs (#5678)
264a441 
* Update README.rst

#5677

* Update conf.py

* Update conf.py

* Fix html_logo rel path in `conf.py`

* Keep the branch name in the logo URI in README

* Move html logo definition to the intended location

* Add a custom CSS file

* Create logo-adjustments.css

* Drop the unused PNG logo from docs assets

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
patchback bot pushed a commit that referenced this issue May 14, 2021
@himanshu007-creator
Use an SVG logo across the docs (#5678)
3a87ea3 
* Update README.rst

#5677

* Update conf.py

* Update conf.py

* Fix html_logo rel path in `conf.py`

* Keep the branch name in the logo URI in README

* Move html logo definition to the intended location

* Add a custom CSS file

* Create logo-adjustments.css

* Drop the unused PNG logo from docs assets

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit 264a441)
@patchback patchback bot mentioned this issue May 14, 2021
Merged
5 tasks
webknjaz pushed a commit that referenced this issue May 14, 2021
@patchback @himanshu007-creator
[PR #5678/264a441a backport][3.8] Use an SVG logo across the docs (#5712
09d5b24 
)

* Update README.rst

#5677

* Update conf.py

* Update conf.py

* Fix html_logo rel path in `conf.py`

* Keep the branch name in the logo URI in README

* Move html logo definition to the intended location

* Add a custom CSS file

* Create logo-adjustments.css

* Drop the unused PNG logo from docs assets

Co-authored-by: Sviatoslav Sydorenko <[email protected]>
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
(cherry picked from commit 264a441)

Co-authored-by: Himanshu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement good first issue Good for newcomers Hacktoberfest We think it's good for https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use an SVG logo across the docs
1 participant
@webknjaz