Use an SVG logo across the docs

[himanshu007-creator]

What do these changes do?

This patch switches the png logo with an SVG one.

Are there changes in behavior for the user?

The logo in the docs looks nicer when zoomed in.

Related issue number

Resolves #5677

Checklist

• I think the code is well written
• Unit tests for the changes exist
• Documentation reflects the changes
• If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • The format is <Name> <Surname>.
  • Please keep alphabetical order, the file is sorted by names.
• Add a new news fragment into the CHANGES folder
  • name it <issue_id>.<type> for example (588.bugfix)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of the following:
    • .feature: Signifying a new feature.
    • .bugfix: Signifying a bug fix.
    • .doc: Signifying a documentation improvement.
    • .removal: Signifying a deprecation or removal of public API.
    • .misc: A ticket has been closed, but it is not of interest to users.
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

[webknjaz]

@himanshu007-creator thanks for looking into this. While I see that this change is useful, that issue was about the sphinx docs logo set in the docs/conf.py. Could you please include that change here too?

[himanshu007-creator]

@himanshu007-creator thanks for looking into this. While I see that this change is useful, that issue was about the sphinx docs logo set in the docs/conf.py. Could you please include that change here too?

Will do it today👍

[webknjaz]

Looks like more changes are needed to make this work. It currently generates a link to a non-existent file (which is visible here https://aiohttp--5678.org.readthedocs.build/en/5678/). I suppose it may be necessary to add an html_logo var so sphinx would copy it to the static dir during the build.

[himanshu007-creator]

Looks like more changes are needed to make this work. It currently generates a link to a non-existent file (which is visible here https://aiohttp--5678.org.readthedocs.build/en/5678/). I suppose it may be necessary to add an html_logo var so sphinx would copy it to the static dir during the build.

okay, so i will create a var
html_logo="https://raw.githubusercontent.com/aio-libs/aiohttp/4d58400477331704132cc9427d66699e5815ee25/docs/aiohttp-plain.svg"

Then assign "logo":html_logo

is this the correct way?

[webknjaz]

No, only use a file name in that var, no need to have a URL coupled to GitHub. Check the Sphinx docs for more details, if necessary.

[codecov]

Codecov Report

Merging #5678 (ffb2887) into master (4d58400) will not change coverage.
The diff coverage is n/a.

❗ Current head ffb2887 differs from pull request most recent head efc816f. Consider uploading reports for the commit efc816f to get more accurate results

@@           Coverage Diff           @@
##           master    #5678   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          41       41           
  Lines        8865     8865           
  Branches     1425     1425           
=======================================
  Hits         8615     8615           
  Misses        133      133           
  Partials      117      117           

Flag	Coverage Δ
unit	97.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d58400...efc816f. Read the comment docs.

[himanshu007-creator]

No, only use a file name in that var, no need to have a URL coupled to GitHub. Check the Sphinx docs for more details, if necessary.

can you tell the required changes please

[webknjaz]

Thanks!

[patchback]

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/264a441acf7d0d01bf34c3bedbaf05b0e0bb43a6/pr-5678

Backported as #5712

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.