Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allows reorg detectors configure the what kind of block is a finalized block #180

Merged
merged 12 commits into from
Feb 6, 2025
Merged

feat: allows reorg detectors configure the what kind of block is a finalized block #180

merged 12 commits into from
Feb 6, 2025

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Feb 4, 2025 •
edited
Loading

Fixes #176

Description

  • Reorg detector allow to configure the what kind of block is a finalized block (ReorgDetectorLX.FinalizedBlock)
  • Syncers use finalizedBlock configuration from reorgDetector
  • Fix e2e test for bridgesyncer that sometimes fails because a forced reorg affect to a finalized block

Configuration

[ReorgDetectorL1]
DBPath = "{{PathRWData}}/reorgdetectorl1.sqlite"
FinalizedBlock="FinalizedBlock"

[ReorgDetectorL2]
DBPath = "{{PathRWData}}/reorgdetectorl2.sqlite"
FinalizedBlock="LatestBlock"

@joanestebanr joanestebanr self-assigned this Feb 4, 2025
@joanestebanr joanestebanr changed the title feat: wip feat: allows reorg detectors configure the what kind of block is a finalized block Feb 5, 2025
@joanestebanr joanestebanr force-pushed the feature/syncer_blockfinality_configured_reorgdetector_176 branch from ca91c0a to a32c43c Compare February 5, 2025 10:52
@joanestebanr joanestebanr marked this pull request as ready for review February 5, 2025 16:26
ToniRamirezM
ToniRamirezM approved these changes Feb 6, 2025
View reviewed changes
reorgdetector/config.go Show resolved Hide resolved
@joanestebanr joanestebanr mentioned this pull request Feb 6, 2025
Merged
goran-ethernal
goran-ethernal approved these changes Feb 6, 2025
View reviewed changes
reorgdetector/reorgdetector.go Outdated Show resolved Hide resolved
reorgdetector/config.go Outdated Show resolved Hide resolved
bridgesync/e2e_test.go Outdated Show resolved Hide resolved
Stefan-Ethernal
Stefan-Ethernal approved these changes Feb 6, 2025
View reviewed changes
reorgdetector/config.go Show resolved Hide resolved
reorgdetector/reorgdetector.go Outdated Show resolved Hide resolved
sync/evmdriver.go Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joanestebanr joanestebanr merged commit 270f6bc into develop Feb 6, 2025
11 checks passed
@joanestebanr joanestebanr deleted the feature/syncer_blockfinality_configured_reorgdetector_176 branch February 6, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@ToniRamirezM ToniRamirezM ToniRamirezM approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@joanestebanr joanestebanr

Labels
aggsender cli & config sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joanestebanr @ToniRamirezM @Stefan-Ethernal @goran-ethernal