Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncer must configure finalized Block from reorg detector attached. #176

Open
Tracked by #39
joanestebanr opened this issue Jan 30, 2025 · 0 comments
Open
Tracked by #39

Syncer must configure finalized Block from reorg detector attached. #176

joanestebanr opened this issue Jan 30, 2025 · 0 comments
Assignees
@joanestebanr
Labels
enhancement New feature or request

Comments

@joanestebanr
Copy link
Contributor

  • Syncer must ask for finalized block to the reorg detector attached instead of hardcoded value (

    aggkit/cmd/run.go

    Line 542 in e141db2

    etherman.LatestBlock,
    ) :
    • This allow a more compact configuration
    • The reorg detector + syncer is going to be in the same page
  • The rorg detector must have this value in configuration
    • In some cases L2 RPC doesn't have the 'finalized' Block as L2 and returns always a 0.

Also must be a way to disable reorg detector and the code on evmdownloader that request for latest FinalizedBlock.
@joanestebanr joanestebanr added the enhancement New feature or request label Jan 30, 2025
@joanestebanr joanestebanr self-assigned this Jan 30, 2025
This was referenced Jan 27, 2025
Open
Merged
joanestebanr added a commit that referenced this issue Feb 6, 2025
@joanestebanr
feat: allows reorg detectors configure the what kind of block is a fi…
270f6bc 
…nalized block (#180)

Fixes #176
## Description
- Reorg detector allow to configure the what kind of block is a finalized block (`ReorgDetectorLX.FinalizedBlock`)
- Syncers use finalizedBlock configuration from reorgDetector
- Fix e2e test for bridgesyncer that sometimes fails because a forced reorg affect to a finalized block

## Configuration
```
[ReorgDetectorL1]
DBPath = "{{PathRWData}}/reorgdetectorl1.sqlite"
FinalizedBlock="FinalizedBlock"

[ReorgDetectorL2]
DBPath = "{{PathRWData}}/reorgdetectorl2.sqlite"
FinalizedBlock="LatestBlock"
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanestebanr joanestebanr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joanestebanr