Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prevent missconfiguration of bridgeAddress in bridgesyncer #187

Merged

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Feb 6, 2025

Description

  • A common mistake is to set the variable polygonBridgeAddr inside the section [L1Config] in config file. This is prevented with the list of deprecated variables on config file
  • Another possible error is to set the wrong address. To fix that the code checks that the contract is the bridge one testing a method.

Fixes #167

@joanestebanr joanestebanr changed the title feat: Avoid miss configuration of bridgeAddress in bridgesyncer feat: Prevent missconfiguration of bridgeAddress in bridgesyncer Feb 6, 2025
@joanestebanr joanestebanr marked this pull request as ready for review February 6, 2025 11:29
@joanestebanr joanestebanr force-pushed the feature/avoid_error_setting_bridge_address_167 branch from 18cf0fe to af46678 Compare February 6, 2025 15:52
@joanestebanr joanestebanr self-assigned this Feb 6, 2025
@joanestebanr joanestebanr added enhancement New feature or request aggsender sync labels Feb 6, 2025
@joanestebanr joanestebanr merged commit 73b5449 into develop Feb 7, 2025
11 checks passed
@joanestebanr joanestebanr deleted the feature/avoid_error_setting_bridge_address_167 branch February 7, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aggsender enhancement New feature or request sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants