Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbTests: Set remote_tmp for Unix VPC runs #1736

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

Willsparker
Copy link
Contributor

Fixes: #1722

Checklist

@Willsparker Willsparker added this to the December 2020 milestone Dec 4, 2020
@Willsparker Willsparker requested review from sxa and gdams December 4, 2020 10:25
@Willsparker Willsparker self-assigned this Dec 4, 2020
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm why is this needed when https://github.com/AdoptOpenJDK/openjdk-infrastructure/blob/14272c35b38fe04a54759ba3425d181b5d975390/ansible/ansible.cfg#L31 is in the file already? Can we do something that will make that activate properly in VPC?

It does worry me that we're forcing the directory like this so would be good to understand why it doesn't work (or whether we can use a neutral directory like /tmp) or at least document why we've got this change

@Willsparker
Copy link
Contributor Author

Willsparker commented Dec 4, 2020

is in the file already? Can we do something that will make that activate properly in VPC?

VPC doesn't use the inventory, so hosts:solaris means nothing to Ansible. We could force it to, by making the temporary host file into something more like the inventory; i.e.

hosts:
  $OS-vagant: {ip: [127.0.0.1]:$vagrantPort}

It does worry me that we're forcing the directory like this so would be good to understand why it doesn't work (or whether we can use a neutral directory like /tmp) or at least document why we've got this change

I believe in most cases $HOME/.ansible/tmp is already the case, it just isn't for Solaris (apparently). However, yeah, I get the concern. I could try the /tmp directory, and then just make sure the vagrant user has the perms to execute from there in the Vagrantfile's provisioning script.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VPC doesn't use the inventory, so hosts:solaris means nothing to Ansible

Hmmm ok we could override the hostname, but if it's just a pattern match there then that explains it. I am somewhat concerned that we have a setup that requires additional tweaking to be able to work though.

@Willsparker Willsparker merged commit 7d0b030 into adoptium:master Dec 4, 2020
karianna added a commit that referenced this pull request Dec 4, 2020
* Fixes from Markdown and Yaml linters + spelling typos

* ansible: refresh macOS test machines + playbook patches (#1665)

* Ansible: refresh macOS test machines + playbook patches

* linter fixes

* Update main.yml

* Update MacOSX.yml

* Update main.yml

* Update main.yml

* Update main.yml

* Update main.yml

* Update MacOSX.yml

* Update MacOSX.yml

* pbTests: Fix -nh option on the VPC help screen (#1735)

Signed-off-by: Stewart X Addison <[email protected]>

* Set remote_tmp for Ansible (#1736)

* aixPB: Remove packages already installed by yum (#1704)

* aixPB: Remove packages already installed via yum: statements

* aixPB: Add additional tag 'yum' to a task

* aixPB: Add additional tag 'yum' to a task

* aixPB: Modify order of executition to have requirements first (#1695)

* aixPB: Modify order of so-called role executition to have requirements first

* aixPB: GNU software needed for some of the Ansible modules used in other plays

* aixPB: Remove spurious comments

* aixPB: Organize (and document/motivate) six groups of roles.
* move aixfs configuration to precede yum - to ensure sufficient FS space for
  the yum installed packages.
* move XLC installation to after yum processing to ensure Ansible unarchive
  module requirements are available.

* aixPB: Remove trailing space

* aixPB: move X11 (AIX BOS) installation check to after OSS core installation
because it might need the Ansible unarchive: module.
Also, number the role grouping to imporve recognition of 'sections'

* doc: typo corrections and header modifications (#1734)

* Fixes from Markdown and Yaml linters + spelling typos

* fix to URL from Stewart review

Co-authored-by: George Adams <[email protected]>
Co-authored-by: Stewart X Addison <[email protected]>
Co-authored-by: Will Parker <[email protected]>
Co-authored-by: Michael Felt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solaris playbook cannot locate CSWpkgutil.pkg
3 participants