Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes from Markdown and Yaml linters + spelling typos #1733

Merged
merged 10 commits into from
Dec 4, 2020
Merged

Fixes from Markdown and Yaml linters + spelling typos #1733

merged 10 commits into from
Dec 4, 2020

Conversation

karianna
Copy link
Contributor

@karianna karianna commented Dec 3, 2020

Checklist
  • commit message has one of the standard prefixes
  • FAQ.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • inventory changes, ensure bastillion is updated accordingly

karianna and others added 3 commits December 3, 2020 12:23
@karianna
Fixes from Markdown and Yaml linters + spelling typos
f4dfd9d
@gdams
ansible: refresh macOS test machines + playbook patches (adoptium#1665)
2d01b8a 
* Ansible: refresh macOS test machines + playbook patches

* linter fixes

* Update main.yml

* Update MacOSX.yml

* Update main.yml

* Update main.yml

* Update main.yml

* Update main.yml

* Update MacOSX.yml

* Update MacOSX.yml
@sxa
pbTests: Fix -nh option on the VPC help screen (adoptium#1735)
14272c3 
Signed-off-by: Stewart X Addison <[email protected]>
sxa
sxa approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issues relating to the group names being out of date, but I'll approve regardless as they can be resolved in other PRs if you don't want to do it here. Thanks for the changes, although is there a specific reason why you switched all the URLs to be around [URL](url) instead of just having them raw in the file since github renders URLs in the same way I believe (and it avoids duplication of the address)

.github/workflows/build_vagrant.yml Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
ONBOARDING.md
* [@admin_infrastructure](https://github.com/orgs/AdoptOpenJDK/teams/admin_infrastructure) - Super Users
* [@infrastructure](https://github.com/orgs/AdoptOpenJDK/teams/infrastructure) - Core Infra Team
* [@adoptopenjdk-infrastructure](https://github.com/orgs/AdoptOpenJDK/teams/adoptopenjdk-infrastructure) - Can be assigned Infra Issues
* [@jenkins-admins](https://github.com/orgs/AdoptOpenJDK/teams/jenkins-admins) - Super users on Jenkins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section likely needs a bit of an update now that #1084 is complete, but I'm happy for that to be left for a separate PR

Willsparker and others added 4 commits December 4, 2020 11:12
@Willsparker
Set remote_tmp for Ansible (adoptium#1736)
7d0b030
@aixtools
aixPB: Remove packages already installed by yum (adoptium#1704)
a6986ac 
* aixPB: Remove packages already installed via yum: statements

* aixPB: Add additional tag 'yum' to a task

* aixPB: Add additional tag 'yum' to a task
@aixtools
aixPB: Modify order of executition to have requirements first (adopti…
0bf2053 
…um#1695)

* aixPB: Modify order of so-called role executition to have requirements first

* aixPB: GNU software needed for some of the Ansible modules used in other plays

* aixPB: Remove spurious comments

* aixPB: Organize (and document/motivate) six groups of roles.
* move aixfs configuration to precede yum - to ensure sufficient FS space for
  the yum installed packages.
* move XLC installation to after yum processing to ensure Ansible unarchive
  module requirements are available.

* aixPB: Remove trailing space

* aixPB: move X11 (AIX BOS) installation check to after OSS core installation
because it might need the Ansible unarchive: module.
Also, number the role grouping to imporve recognition of 'sections'
@aixtools
doc: typo corrections and header modifications (adoptium#1734)
2c0dc98
@karianna
Copy link
Contributor Author

karianna commented Dec 4, 2020

Minor issues relating to the group names being out of date, but I'll approve regardless as they can be resolved in other PRs if you don't want to do it here. Thanks for the changes, although is there a specific reason why you switched all the URLs to be around [URL](url) instead of just having them raw in the file since GitHub renders URLs in the same way I believe (and it avoids duplication of the address)

Markdown Linter told me off :-)

@karianna karianna added the bug label Dec 4, 2020
@karianna karianna added this to the December 2020 milestone Dec 4, 2020
@karianna karianna requested a review from sxa December 4, 2020 17:51
@karianna karianna merged commit 678781e into adoptium:master Dec 4, 2020
@sxa
Copy link
Member

sxa commented Dec 4, 2020

Markdown Linter told me off :-)

Harsh! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa Awaiting requested review from sxa

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
December 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@karianna @sxa @gdams @Willsparker @aixtools