Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aixPB: Remove packages already installed by yum #1704

Merged
merged 3 commits into from
Dec 4, 2020
Merged

aixPB: Remove packages already installed by yum #1704

merged 3 commits into from
Dec 4, 2020

Conversation

aixtools
Copy link
Contributor

@aixtools aixtools commented Nov 24, 2020

Checklist

The playbook includes packages not available, directly, using yum. RPM's previously not available, are now available and need to be removed from the 'additional' packages list.

This replaces #1411

@karianna karianna added the bug label Nov 24, 2020
@karianna karianna added this to the November 2020 milestone Nov 24, 2020
@aixtools aixtools changed the title Remove packages already installed by yum aixPB: Remove packages already installed by yum Nov 25, 2020
@Haroon-Khel
Copy link
Contributor

Haroon-Khel commented Nov 26, 2020

Received an unfamilar error when running the yum role

TASK [Install yum and dependencies] *****************************************************************************************************************************************************************************************************************************************************
task path: /Users/hkhel/AdoptOpenJDK/openjdk-infrastructure/ansible/playbooks/AdoptOpenJDK_AIX_Playbook/roles/yum/tasks/main.yml:34
fatal: [p9-aix1-ojdk06.osuosl.org]: FAILED! => {"msg": "Invalid variable name in 'register' specified: 'result.yum'"}

This doesnt look related to your changes but is stopping the yum role from succeeding.

The variable result.yum is not referenced anywhere else in that role, so I think it safe to say that the line can be deleted

@Haroon-Khel
Copy link
Contributor

Haroon-Khel commented Nov 26, 2020

Also, I believe the yum role should run as one of the first roles, as it installs unzip and tar, both needed for the x11, xlc13 and xlc16 roles (and any other which involves decompressing and unzipping packages). The change would be more suitable in your other pr

@aixtools
Copy link
Contributor Author

Also, I believe the yum role should run as one of the first roles, as it installs unzip and tar, both needed for the x11, xlc13 and xlc16 roles (and any other which involves decompressing and unzipping packages). The change would be more suitable in your other pr

Looking at xlc13 - the vendor file is packed using gzip, not unzip - and depending on module logic AIX gzip and tar are fine for unpacking. If unarchive: demands GNU zip then a shell: command such as gzip -dc {{ filename }} | ( cd /tmp; tar xf -)

Note: read unarchive Ansible module: states it requires zipinfo, unzip and gtar.

This could be rewritten to use shell: and remove the module requirements.

@@ -94,9 +94,6 @@
- name: Install yum package support
yum: name={{ item }} state=present update_cache=yes
with_items:
- http://www.bullfreeware.com/download/bin/2328/libiconv-1.14-22.aix6.1.ppc.rpm
- http://www.bullfreeware.com/download/bin/2591/libunistring-0.9.6-2.aix6.1.ppc.rpm
- http://www.bullfreeware.com/download/bin/3944/perl-5.24.0-3.aix6.1.ppc.rpm
- http://www.oss4aix.org/download/RPMS/cmake/cmake-3.7.2-1.aix6.1.ppc.rpm
tags: rpm_install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add yum tags to this task and the one below it please. The proper syntax is

  tags: 
    - rpm_install
    - yum

@Haroon-Khel
Copy link
Contributor

@aixtools (same as #1695) this pr is ready to be merged (after the requested changes have been put in)

Copy link
Contributor

@Haroon-Khel Haroon-Khel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aixtools
Copy link
Contributor Author

aixtools commented Dec 4, 2020

thx @Haroon-Khel

@Haroon-Khel Haroon-Khel merged commit a6986ac into adoptium:master Dec 4, 2020
@aixtools aixtools deleted the aix-pb2-yum branch December 4, 2020 13:54
karianna added a commit that referenced this pull request Dec 4, 2020
* Fixes from Markdown and Yaml linters + spelling typos

* ansible: refresh macOS test machines + playbook patches (#1665)

* Ansible: refresh macOS test machines + playbook patches

* linter fixes

* Update main.yml

* Update MacOSX.yml

* Update main.yml

* Update main.yml

* Update main.yml

* Update main.yml

* Update MacOSX.yml

* Update MacOSX.yml

* pbTests: Fix -nh option on the VPC help screen (#1735)

Signed-off-by: Stewart X Addison <[email protected]>

* Set remote_tmp for Ansible (#1736)

* aixPB: Remove packages already installed by yum (#1704)

* aixPB: Remove packages already installed via yum: statements

* aixPB: Add additional tag 'yum' to a task

* aixPB: Add additional tag 'yum' to a task

* aixPB: Modify order of executition to have requirements first (#1695)

* aixPB: Modify order of so-called role executition to have requirements first

* aixPB: GNU software needed for some of the Ansible modules used in other plays

* aixPB: Remove spurious comments

* aixPB: Organize (and document/motivate) six groups of roles.
* move aixfs configuration to precede yum - to ensure sufficient FS space for
  the yum installed packages.
* move XLC installation to after yum processing to ensure Ansible unarchive
  module requirements are available.

* aixPB: Remove trailing space

* aixPB: move X11 (AIX BOS) installation check to after OSS core installation
because it might need the Ansible unarchive: module.
Also, number the role grouping to imporve recognition of 'sections'

* doc: typo corrections and header modifications (#1734)

* Fixes from Markdown and Yaml linters + spelling typos

* fix to URL from Stewart review

Co-authored-by: George Adams <[email protected]>
Co-authored-by: Stewart X Addison <[email protected]>
Co-authored-by: Will Parker <[email protected]>
Co-authored-by: Michael Felt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants