Review fixes https://github.com/adobe/brackets/pull/4382 #4442
Conversation
ghost
assigned 
|
Hi @shevchuk -- just FYI, in the future you can just push new commits up to the same branch and they'll get automatically included in the original pull request--no need to close it and reopen a new one. Thanks. |
|
Hi @njx, sorry, will absolutely follow your advice. |
|
No problem, thanks again for working on this. |
| * File names which are not showed in quick open dialog | ||
| * @type {RegExp} | ||
| */ | ||
| var _binaryExclusionListRegEx = /\.svgz$|^\.jsz$|^\.zip$|^\.gz$|^\.htmz$|^\.htmlz$|^\.rar$|^\.tar$|^\.exe$|^\.bin$/; |
There was a problem hiding this comment.
You don't want the ^s here -- that means only ".zip" will match, not "foo.zip". The only reason the _exclusionListRegEx uses ^ is because it really is filtering out exact names in those cases (e.g. ".svn" isn't an extension, it's a complete folder name).
|
@shevchuk just two more comments (see above) and then we can merge |
|
@peterflynn thanks for pointing to that place that makes indices. |
|
@peterflynn finished, please review last commit |
|
Thanks @shevchuk, looks good! Merging now... |
…view-1 Exclude certain known binary files types from FileIndexManager (and thus Quick Open, Find in Files, etc.)
|
Note: this is related to the larger user story for excluding things from search in general. |
@peterflynn here is a fix for you comments in #4382