Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Review fixes https://github.com/adobe/brackets/pull/4382 #4115

Open
core-ai-bot opened this issue Aug 29, 2021 · 8 comments

Comments

@core-ai-bot
Copy link
Member

Issue by shevchuk
Friday Jul 12, 2013 at 15:59 GMT
Originally opened as adobe/brackets#4442


@peterflynn here is a fix for you comments in adobe/brackets#4382


shevchuk included the following code: https://github.com/adobe/brackets/pull/4442/commits

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Jul 15, 2013 at 19:19 GMT


Hi@shevchuk -- just FYI, in the future you can just push new commits up to the same branch and they'll get automatically included in the original pull request--no need to close it and reopen a new one. Thanks.

@core-ai-bot
Copy link
Member Author

Comment by shevchuk
Monday Jul 15, 2013 at 19:32 GMT


Hi@njx, sorry, will absolutely follow your advice.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Jul 15, 2013 at 19:44 GMT


No problem, thanks again for working on this.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Jul 18, 2013 at 17:54 GMT


@shevchuk just two more comments (see above) and then we can merge

@core-ai-bot
Copy link
Member Author

Comment by shevchuk
Friday Jul 19, 2013 at 10:06 GMT


@peterflynn thanks for pointing to that place that makes indices.

@core-ai-bot
Copy link
Member Author

Comment by shevchuk
Friday Jul 19, 2013 at 11:01 GMT


@peterflynn finished, please review last commit

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Jul 22, 2013 at 21:03 GMT


Thanks@shevchuk, looks good! Merging now...

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Monday Jul 22, 2013 at 21:07 GMT


Note: this is related to the larger user story for excluding things from search in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant