This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Hide zipped(binary) filenames from quick open dialog #4382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
This should probably live in ProjectManager so it can sit next to ProjectManager.shouldShow()...
Both these file-typing utility methods should be on a similar path of evolution, something like this:
- Initially: Easily patchable & reusable
- Later: Extensible
- Later still: User-editable (i.e. make it a preference)
There was a problem hiding this comment.
One other way that this and shouldShow() don't parallel each other is that shouldShow() uses a regexp. I think that's ok for now (in fact, shouldShow() used an array too up until 8d40193, and I'm guessing it will need to switch back eventually when the list becomes less hardcoded...).
ghost
assigned 
|
@shevchuk done reviewing. Thanks for signing the CLA, too! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is sometimes hard to choose specific file using quick open because there are minified zipped files among the list.