dev -> staging (core-v3.2.0) #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename DelegateGateNotMet` to `SuppressedByAppDeveloper`. - update conflict and suppressed by app developer error reasons to match the ones in-use in the iOS core
add `SuppressedByAppDeveloper` to `PresentationError` interface
add new error codes for AdobeError
Update versions [Core-3.2.0]
the coroutine children cancellation was causing all other coroutines other than the first to be cancelled early. this led to some race condition like behavior when determining if a presentable conflict had occurred. removing the children cancellation should have no effect on the event handling done in the `DefaultInAppMessageEventHandler`.
remove cancellation of coroutine children
prudrabhat
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AEPError.SuppressedByAppDeveloperconstant to indicate that the in-app message was not displayed because it was rejected by the app developer via thePresentationDelegate.