Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SuppressedByAppDeveloper to PresentationError interface #712

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

rymorale
Copy link
Contributor

@rymorale rymorale commented Sep 24, 2024

Description

  • rename DelegateGateNotMet to SuppressedByAppDeveloper.
  • update conflict and suppressed by app developer error reasons to match the ones in-use on the iOS side

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- rename DelegateGateNotMet` to `SuppressedByAppDeveloper`.
- update conflict and suppressed by app developer error reasons to match the ones in-use in the iOS core
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.20%. Comparing base (c6d4395) to head (c2253a1).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
.../marketing/mobile/services/ui/PresentationError.kt 66.67% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c6d4395) and HEAD (c2253a1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c6d4395) HEAD (c2253a1)
functional-tests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #712       +/-   ##
=============================================
- Coverage     81.64%   69.20%   -12.44%     
+ Complexity     2150     1950      -200     
=============================================
  Files           192      192               
  Lines          8975     8978        +3     
  Branches       1125     1125               
=============================================
- Hits           7327     6213     -1114     
- Misses         1090     2298     +1208     
+ Partials        558      467       -91     
Flag Coverage Δ
functional-tests ?
unit-tests 69.20% <80.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...adobe/marketing/mobile/services/ui/Presentation.kt 88.89% <ø> (ø)
...keting/mobile/services/ui/common/AEPPresentable.kt 94.74% <100.00%> (+0.03%) ⬆️
.../marketing/mobile/services/ui/PresentationError.kt 83.33% <66.67%> (-16.67%) ⬇️

... and 39 files with indirect coverage changes

@rymorale rymorale merged commit 6abb3b4 into adobe:dev Sep 24, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants