Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new error codes for AdobeError #713

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

ishita-gambhir-adobe
Copy link
Contributor

Description

Adding new error codes for AdobeError.
These error codes are in parity with Error codes present in AEPError for iOS.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.61%. Comparing base (6abb3b4) to head (6a742cc).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev     #713       +/-   ##
=============================================
+ Coverage     69.21%   81.61%   +12.39%     
- Complexity     1951     2150      +199     
=============================================
  Files           192      192               
  Lines          8978     8982        +4     
  Branches       1125     1125               
=============================================
+ Hits           6214     7330     +1116     
+ Misses         2298     1093     -1205     
- Partials        466      559       +93     
Flag Coverage Δ
functional-tests 27.81% <0.00%> (?)
unit-tests 69.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...in/java/com/adobe/marketing/mobile/AdobeError.java 85.71% <100.00%> (+5.71%) ⬆️

... and 39 files with indirect coverage changes

@praveek praveek merged commit 037baca into adobe:dev Sep 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants