Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Central host UI files #40

Merged
merged 4 commits into from
Aug 1, 2024
Merged

feat: Central host UI files #40

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddd2349
import preview.js from githubpages
FentPams Aug 1, 2024
03d9f76
correct the redirection path and delete the preivew files
FentPams Aug 1, 2024
0ee2b4d
update eslint disable comment
FentPams Aug 1, 2024
cbf0a4d
fix: failing CSS linting when no file available
ramboz Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,11 @@
return;
}
// eslint-disable-next-line import/no-cycle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to update the eslint disable comment her so it doesn't fail the lining.
The "no-cycle" is not needed anymore, but you'll need a "no-unresolved"

const preview = await import('./preview.js');
preview.default(document, pluginOptions);
const preview = await import('https://adobe.github.io/aem-experimentation/preview.js');

Check failure on line 921 in src/index.js

View workflow job for this annotation

GitHub Actions / build 

Unable to resolve path to module 'https://adobe.github.io/aem-experimentation/preview.js'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized this actually redirects to https://opensource.adobe.com/aem-experimentation/preview.js, so we could update the links to the final URL already :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I also updated the path in gh-pages preview.js to https://opensource.adobe.com/aem-experimentation/preview.css

const context = {
getMetadata,
toClassName,
debug,
};
preview.default.call(context, document, pluginOptions);
}
Loading