Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Central host UI files #40

Merged
merged 4 commits into from
Aug 1, 2024
Merged

feat: Central host UI files #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddd2349
import preview.js from githubpages
FentPams Aug 1, 2024
03d9f76
correct the redirection path and delete the preivew files
FentPams Aug 1, 2024
0ee2b4d
update eslint disable comment
FentPams Aug 1, 2024
cbf0a4d
fix: failing CSS linting when no file available
ramboz Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"main": "src/index.js",
"scripts": {
"lint:js": "eslint src",
"lint:css": "stylelint src/**/*.css",
"lint:css": "stylelint src/**/*.css --allow-empty-input",
"lint": "npm run lint:js && npm run lint:css",
"start": "http-server . -p 3000",
"test": "playwright test"
Expand Down
11 changes: 8 additions & 3 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,12 @@
if (!isDebugEnabled) {
return;
}
// eslint-disable-next-line import/no-cycle
const preview = await import('./preview.js');
preview.default(document, pluginOptions);
// eslint-disable-next-line import/no-unresolved
const preview = await import('https://opensource.adobe.com/aem-experimentation/preview.js');
const context = {
getMetadata,
toClassName,
debug,
};
preview.default.call(context, document, pluginOptions);

Check warning on line 927 in src/index.js

View check run for this annotation

Codecov / codecov/patch

src/index.js#L921-L927 

Added lines #L921 - L927 were not covered by tests
}
289 changes: 0 additions & 289 deletions src/preview.css
View file
Open in desktop

This file was deleted.

Loading
Loading