feat: Central host UI files #40
Conversation
|
@ramboz branch is ready :) |
src/index.js
Outdated
| @@ -918,6 +918,11 @@ export async function loadLazy(document, options = {}) { | |||
| return; | |||
| } | |||
| // eslint-disable-next-line import/no-cycle | |||
| const preview = await import('./preview.js'); | |||
| preview.default(document, pluginOptions); | |||
| const preview = await import('https://adobe.github.io/aem-experimentation/preview.js'); | |||
There was a problem hiding this comment.
Just realized this actually redirects to https://opensource.adobe.com/aem-experimentation/preview.js, so we could update the links to the final URL already :)
There was a problem hiding this comment.
Done. I also updated the path in gh-pages preview.js to https://opensource.adobe.com/aem-experimentation/preview.css
src/index.js
Outdated
| @@ -918,6 +918,11 @@ export async function loadLazy(document, options = {}) { | |||
| return; | |||
| } | |||
| // eslint-disable-next-line import/no-cycle | |||
There was a problem hiding this comment.
Just need to update the eslint disable comment her so it doesn't fail the lining.
The "no-cycle" is not needed anymore, but you'll need a "no-unresolved"
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #40 +/- ##
=====================================
Coverage ? 93.40%
=====================================
Files ? 1
Lines ? 682
Branches ? 11
=====================================
Hits ? 637
Misses ? 34
Partials ? 11 ☔ View full report in Codecov by Sentry. |
Description
The branch with preview files:
https://github.com/adobe/aem-experimentation/tree/gh-pages
Todo:
Configure the adobe.github.io to point to the gh-pages branch.
Types of changes
Checklist: