Chore: Using testContainsOrNotExists helper function and tidy up of getData call #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cahirodoherty-learningpool
requested review from
ethan-lp,
eleanor-heath and
lemmyadams
lemmyadams
approved these changes
Jan 31, 2024
ethan-lp
approved these changes
Feb 1, 2024
eleanor-heath
approved these changes
Feb 1, 2024
|
The only other thing this pr could need, is to find an instance of the boxmenu. It assumes that the / is a boxmenu |
|
🎉 This PR is included in version 6.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #176
Chore