Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are using promised callback when it is unnecessary #176

Closed
cahirodoherty-learningpool opened this issue Jan 31, 2024 · 0 comments
Closed

Tests are using promised callback when it is unnecessary #176

cahirodoherty-learningpool opened this issue Jan 31, 2024 · 0 comments
Assignees
@cahirodoherty-learningpool

Comments

@cahirodoherty-learningpool
Copy link
Contributor

Subject of the issue/enhancement/features

The built-in tests command for getData() means the nested this context reading is not necessary. This should be brought out to match the desired convention going forward
Merged
@cahirodoherty-learningpool cahirodoherty-learningpool moved this from New to Needs Reviewing in adapt_framework: The TODO Board Jan 31, 2024
@cahirodoherty-learningpool cahirodoherty-learningpool moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cahirodoherty-learningpool cahirodoherty-learningpool

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cahirodoherty-learningpool