Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Check landing page is a boxmenu type menu #179

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Fix: Check landing page is a boxmenu type menu #179

merged 4 commits into from
Feb 12, 2024

Conversation

cahirodoherty-learningpool
Copy link
Contributor

@cahirodoherty-learningpool cahirodoherty-learningpool commented Feb 6, 2024 •
edited
Loading

Fixes: #178

Fix

  • Check landing page is a boxmenu type menu

joe-allen-89
joe-allen-89 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works nicely. @cahirodoherty-learningpool happy for me to hold release until you've had a reply from Ollie in the issue?

@cahirodoherty-learningpool
Copy link
Contributor Author

👍 works nicely. @cahirodoherty-learningpool happy for me to hold release until you've had a reply from Ollie in the issue?

Thanks Joe, Yeah there will be a bit of a change to this depending on Ollie's reply so can hold off for now

@cahirodoherty-learningpool
Copy link
Contributor Author

@oliverfoster Thanks for the tip on this one. I've included your suggestion now

@oliverfoster oliverfoster merged commit b8ba030 into master Feb 12, 2024
@oliverfoster oliverfoster deleted the issue/178 branch February 12, 2024 10:30
github-actions bot pushed a commit that referenced this pull request Feb 12, 2024
@semantic-release-bot
Chore(release): 6.5.2 [skip ci]
0d95be1 
## [6.5.2](v6.5.1...v6.5.2) (2024-02-12)

### Chore

* Using testContainsOrNotExists helper function and tidy up of getData call (#177) ([6f2ab4f](6f2ab4f)), closes [#177](#177)

### Fix

* Check landing page is a boxmenu type menu (#179) ([b8ba030](b8ba030)), closes [#179](#179)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmyadams lemmyadams lemmyadams approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@ethan-lp ethan-lp Awaiting requested review from ethan-lp

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Box Menu tests need to detect if the landing page is a boxmenu
5 participants
@cahirodoherty-learningpool @oliverfoster @eleanor-heath @joe-allen-89 @lemmyadams