-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace in files on network drive? #56
Comments
ok, that does work but I am (not surprisingly) unable to then use my *.html wildcard as in my example above. The parent folder has thousands of files I am looking through for replacement so guessing I am just out-of-luck for now? |
Yes I see what you mean. Unfortunately I am unable to test this myself as I don't have access to any windows machines or network drives. Would you be able to look into this and dig deeper to see if you can find a solution? Maybe this thread can help: isaacs/node-glob#74 |
Perhaps it's sufficient if we allow you to pass in the |
As a followup, I did get this working as a POC locally (at least for the sync version). It was fairly straightforward and, yes, @adamreisnz it was really just a question of supporting the Here's a summation of what I found in case I have time to create a PR later or someone else has the time. Again, this was just a POC to get working with the
That was what was needed to support the
I hope this helps. |
Thanks @jschuman, if I have time myself I'll look at implementing support for the |
@jschuman I have added support for the cwd parameter in 4.0.0, would you mind taking it for a spin and see if it resolves the issue you had? |
* Bump dependencies * [feature] #38 Count number of matches * Update make-replacements.js * [feature] #42 Differentiate number of matches and number of replacements * [enhance] #56 Support for CWD parameter * Default config value * [enhance] #63 Add --quiet flag to supress console output in CLI * Update success-handler.js * Update readme and add change log
@jschuman I'll close this issue now, but if you have a minute and can check if the new version works for you that'd be great. |
I'm having some trouble getting this to work on files on a network drive.
For example, I set my files attribute to something like this:
let files = "\\\\share_name\\Users\\Public\\jschuman\\*.html"
but no file replacements occur (and I know there should be).
Is this possible?
The text was updated successfully, but these errors were encountered: