Number of matches

[mkaragol64]

Hi @adamreisnz

Is it possible to get total number of matches in all files? Or number of total matches file by file? Or both?

[adamreisnz]

Hi @mkaragol64, this is not currently possible, but if someone can tame the replace method implementation in this library to report on how many replacements were made then it should be doable.

Will leave this open for PR's, as I don't have the time to look into it myself at the moment.

[jschuman]

Is this just a question of using the match method to count and accumulate the number of matches prior to calling replace? A good reference point is here.

[adamreisnz]

It would be yes, but I am worried if that might impact performance for large scale replacements. Perhaps it could be enabled and counted only if a flag was passed and set to true.

In addition, currently the library returns an array of files that were changed. If we need to return any other information as well, this would be a breaking change and we'd have to look at returning a result object with various properties, perhaps something like this:

const result = {
  filesChanged: [
    {file: 'foo', numMatches: 10},
    {file: 'bar', numMatches: 13},
  ],
  totalMatches: 23,
};

[adamreisnz]

Implemented in 4.0.0