Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate between not matched and not replaced #42

Closed
jlenos opened this issue Feb 28, 2018 · 4 comments
Closed

Differentiate between not matched and not replaced #42

jlenos opened this issue Feb 28, 2018 · 4 comments
Labels
8.0 feature PR welcome

Comments

@jlenos
Copy link

jlenos commented Feb 28, 2018 •
edited
Loading

I want to be able to tell if a value was matched but not replaced due to the replacement being an identical string. This is in the context of my attempts to do key/value overrides with more specific error handling.
@CxRes
Copy link
Contributor

CxRes commented Mar 15, 2018

On a related note, is it possible to request a list of files where matches were not found?

@adamreisnz
Copy link
Owner

@CxRes yes that seems feasible, do you want to open a separate issue for that?

@CxRes CxRes mentioned this issue Mar 16, 2018
Closed
@adamreisnz adamreisnz added the 8.0 label Mar 18, 2018
@adamreisnz
Copy link
Owner

This original issue also would need breaking changes to the API, so that we can return a more complex data structure as the result of replacements, with more information about what was replaced and what wasn't.

@webstacker webstacker mentioned this issue Nov 1, 2018
Closed
adamreisnz added a commit that referenced this issue Apr 21, 2019
@adamreisnz
[feature] #42 Differentiate number of matches and number of replacements
a4251e5
@adamreisnz
Copy link
Owner

Implemented in 4.0.0

adamreisnz added a commit that referenced this issue Apr 21, 2019
@adamreisnz
4.0.0 (#74)
27f5572 
* Bump dependencies

* [feature] #38 Count number of matches

* Update make-replacements.js

* [feature] #42 Differentiate number of matches and number of replacements

* [enhance] #56 Support for CWD parameter

* Default config value

* [enhance] #63 Add --quiet flag to supress console output in CLI

* Update success-handler.js

* Update readme and add change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.0 feature PR welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamreisnz @CxRes @jlenos