feat(stale-and-close): add new options to change the days before close #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance of getting this reviewed and merged? We are migrating from probot and miss this feature. Thank you so much. |
9 tasks
|
ping! We've got a PR out to work around this but it would be lovely to have native support. |
richardst89
approved these changes
Jan 14, 2021
|
@hross if you are not available to maintain it I am willing to FYI. Just need the rights to merge. |
|
@C0ZEN this looks good to me and I will merge it once you rebase. |
hross
reviewed
Jan 15, 2021
hross
reviewed
Jan 15, 2021
|
I will handle the rebase and naming conventions tomorrow. |
to avoid a breaking change and simplify the configuration the old options 'daysBeforeStale' and 'daysBeforePrClose' are kept and new options are available to override them with 'daysBeforeIssueStale', 'daysBeforePrStale', 'daysBeforeIssueClose' and 'daysBeforePrClose'
also upgrade the parser
it was not configured properly for TypeScript
C0ZEN
force-pushed
the
feature/diff-number-days
branch
from
c6e82d1 to
8784e9d
Compare
C0ZEN
commented
Jan 16, 2021
it was configured to only work with ts and it was not working well to be honest also now the lint scripts will also run prettier
|
@hross FYI it is ready IMO. |
hross
approved these changes
Jan 16, 2021
nijel
added a commit
to nijel/stale
that referenced
this pull request
Feb 4, 2021
When different stale period is used for issues and pull requests, this code uses wrong one. This was probably missed in actions#224 Fixes actions#299
hross
pushed a commit
that referenced
this pull request
Feb 5, 2021
* Fixed should be stale condition When different stale period is used for issues and pull requests, this code uses wrong one. This was probably missed in #224 Fixes #299 * Add tests for #299 Co-authored-by: Geoffrey Testelin <[email protected]>
pllim
added a commit
to pllim/astropy
that referenced
this pull request
Feb 11, 2021
pllim
added a commit
to pllim/astropy
that referenced
this pull request
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #214
Closes #223