-
Notifications
You must be signed in to change notification settings - Fork 369
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(stale-and-close): add new options to change the days before close (
#224) * docs(readme): add new options in the documentation * chore: update the action schema * chore: parse the new arguments * feat(stale-and-close): add new options to change the days before close to avoid a breaking change and simplify the configuration the old options 'daysBeforeStale' and 'daysBeforePrClose' are kept and new options are available to override them with 'daysBeforeIssueStale', 'daysBeforePrStale', 'daysBeforeIssueClose' and 'daysBeforePrClose' * chore: rename the issue type enum to remove the enum suffix * chore: add missing dependency for eslint and typescript also upgrade the parser * chore: fix an issue with the linter for the shadow rules it was not configured properly for TypeScript * chore: use camelCase for constants * chore: use camelCase for enum members * chore: fix the tests * chore: enhance prettier to also lint other kind of files it was configured to only work with ts and it was not working well to be honest also now the lint scripts will also run prettier
- Loading branch information
Showing
19 changed files
with
766 additions
and
202 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,52 +1,57 @@ | ||
| { | ||
| "plugins": ["jest", "@typescript-eslint"], | ||
| "extends": ["plugin:github/recommended"], | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "ecmaVersion": 9, | ||
| "sourceType": "module", | ||
| "project": "./tsconfig.json" | ||
| }, | ||
| "rules": { | ||
| "eslint-comments/no-use": "off", | ||
| "import/no-namespace": "off", | ||
| "no-unused-vars": "off", | ||
| "@typescript-eslint/no-unused-vars": "error", | ||
| "@typescript-eslint/explicit-member-accessibility": ["error", {"accessibility": "no-public"}], | ||
| "@typescript-eslint/no-require-imports": "error", | ||
| "@typescript-eslint/array-type": "error", | ||
| "@typescript-eslint/await-thenable": "error", | ||
| "@typescript-eslint/ban-ts-comment": "error", | ||
| "camelcase": "off", | ||
| "@typescript-eslint/consistent-type-assertions": "error", | ||
| "@typescript-eslint/func-call-spacing": ["error", "never"], | ||
| "@typescript-eslint/no-array-constructor": "error", | ||
| "@typescript-eslint/no-empty-interface": "error", | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
| "@typescript-eslint/no-extraneous-class": "error", | ||
| "@typescript-eslint/no-for-in-array": "error", | ||
| "@typescript-eslint/no-inferrable-types": "error", | ||
| "@typescript-eslint/no-misused-new": "error", | ||
| "@typescript-eslint/no-namespace": "error", | ||
| "@typescript-eslint/no-non-null-assertion": "warn", | ||
| "@typescript-eslint/no-unnecessary-qualifier": "error", | ||
| "@typescript-eslint/no-unnecessary-type-assertion": "error", | ||
| "@typescript-eslint/no-useless-constructor": "error", | ||
| "@typescript-eslint/no-var-requires": "error", | ||
| "@typescript-eslint/prefer-for-of": "warn", | ||
| "@typescript-eslint/prefer-function-type": "warn", | ||
| "@typescript-eslint/prefer-includes": "error", | ||
| "@typescript-eslint/prefer-string-starts-ends-with": "error", | ||
| "@typescript-eslint/promise-function-async": "error", | ||
| "@typescript-eslint/require-array-sort-compare": "error", | ||
| "@typescript-eslint/restrict-plus-operands": "error", | ||
| "semi": "off", | ||
| "@typescript-eslint/type-annotation-spacing": "error", | ||
| "@typescript-eslint/unbound-method": "off" | ||
| }, | ||
| "env": { | ||
| "node": true, | ||
| "es6": true, | ||
| "jest/globals": true | ||
| } | ||
| } | ||
| "plugins": ["jest", "@typescript-eslint"], | ||
| "extends": ["plugin:github/recommended"], | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "ecmaVersion": 9, | ||
| "sourceType": "module", | ||
| "project": "./tsconfig.json" | ||
| }, | ||
| "rules": { | ||
| "eslint-comments/no-use": "off", | ||
| "import/no-namespace": "off", | ||
| "no-unused-vars": "off", | ||
| "@typescript-eslint/no-unused-vars": "error", | ||
| "@typescript-eslint/explicit-member-accessibility": [ | ||
| "error", | ||
| {"accessibility": "no-public"} | ||
| ], | ||
| "@typescript-eslint/no-require-imports": "error", | ||
| "@typescript-eslint/array-type": "error", | ||
| "@typescript-eslint/await-thenable": "error", | ||
| "@typescript-eslint/ban-ts-comment": "error", | ||
| "camelcase": "off", | ||
| "@typescript-eslint/consistent-type-assertions": "error", | ||
| "@typescript-eslint/func-call-spacing": ["error", "never"], | ||
| "@typescript-eslint/no-array-constructor": "error", | ||
| "@typescript-eslint/no-empty-interface": "error", | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
| "@typescript-eslint/no-extraneous-class": "error", | ||
| "@typescript-eslint/no-for-in-array": "error", | ||
| "@typescript-eslint/no-inferrable-types": "error", | ||
| "@typescript-eslint/no-misused-new": "error", | ||
| "@typescript-eslint/no-namespace": "error", | ||
| "@typescript-eslint/no-non-null-assertion": "warn", | ||
| "@typescript-eslint/no-unnecessary-qualifier": "error", | ||
| "@typescript-eslint/no-unnecessary-type-assertion": "error", | ||
| "@typescript-eslint/no-useless-constructor": "error", | ||
| "@typescript-eslint/no-var-requires": "error", | ||
| "@typescript-eslint/prefer-for-of": "warn", | ||
| "@typescript-eslint/prefer-function-type": "warn", | ||
| "@typescript-eslint/prefer-includes": "error", | ||
| "@typescript-eslint/prefer-string-starts-ends-with": "error", | ||
| "@typescript-eslint/promise-function-async": "error", | ||
| "@typescript-eslint/require-array-sort-compare": "error", | ||
| "@typescript-eslint/restrict-plus-operands": "error", | ||
| "semi": "off", | ||
| "@typescript-eslint/type-annotation-spacing": "error", | ||
| "@typescript-eslint/unbound-method": "off", | ||
| "no-shadow": "off", | ||
| "@typescript-eslint/no-shadow": "error" | ||
| }, | ||
| "env": { | ||
| "node": true, | ||
| "es6": true, | ||
| "jest/globals": true | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,4 @@ allowed: | |
| - unlicense | ||
|
|
||
| reviewed: | ||
| npm: | ||
| npm: | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| .idea | ||
| .licenses | ||
| .vscode | ||
| dist | ||
| node_modules | ||
| package-lock.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,10 @@ | ||
| { | ||
| "printWidth": 80, | ||
| "tabWidth": 2, | ||
| "useTabs": false, | ||
| "semi": true, | ||
| "singleQuote": true, | ||
| "trailingComma": "none", | ||
| "bracketSpacing": false, | ||
| "arrowParens": "avoid", | ||
| "parser": "typescript" | ||
| } | ||
| "printWidth": 80, | ||
| "tabWidth": 2, | ||
| "useTabs": false, | ||
| "semi": true, | ||
| "singleQuote": true, | ||
| "trailingComma": "none", | ||
| "bracketSpacing": false, | ||
| "arrowParens": "avoid" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.