Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different number of days for PRs and issues #214

Closed
Tracked by #11070
nijel opened this issue Nov 17, 2020 · 7 comments · Fixed by #224
Closed
Tracked by #11070

Support different number of days for PRs and issues #214

nijel opened this issue Nov 17, 2020 · 7 comments · Fixed by #224
Labels
enhancement New feature or request

Comments

@nijel
Copy link
Contributor

nijel commented Nov 17, 2020

I'm currently using Probot Stale and would like to migrate to this action. One thing which doesn't seem to be possible to configure here is different number of days for PRs and issues.

I can see two approaches that would work for me:

  • Add issue-days-before-stale/pr-days-before-stale and issue-days-before-close/pr-days-before-close settings to override days-before-stale and days-before-close
  • Add process-issue/process-pr boolean flags to disable processing of given types and I'd configure two action runs

I think second approach is better as that makes it easy to diverge any setting for PR and issues while not making the action more complex with every single such diversion.

nijel added a commit to WeblateOrg/meta that referenced this issue Nov 17, 2020
The bot does not seem to run reliably, so try the action instead.

There is downside that the action does not support different limits
for issues and PRs.

See probot/stale#308
See actions/stale#214
@C0ZEN
Copy link
Contributor

C0ZEN commented Nov 22, 2020

@nijel I like the idea but IMO the first one is more simple to understand.

@C0ZEN
Copy link
Contributor

C0ZEN commented Nov 22, 2020

I will provide a PR.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Dec 23, 2020
@C0ZEN
Copy link
Contributor

C0ZEN commented Dec 23, 2020

Up

@github-actions github-actions bot removed the Stale label Dec 24, 2020
@hross hross added the enhancement New feature or request label Jan 15, 2021
nijel added a commit to WeblateOrg/meta that referenced this issue Jan 16, 2021
Now that actions/stale#214 is implemented we
can set desired limits.
@alyssawilk
Copy link

@hross any chance you folks could tag a stale release for this, or should we just pin to specific hashes?
thanks!

@hross
Copy link
Contributor

hross commented Jan 19, 2021

@alyssawilk yup, I am letting it run internally to make sure we don't run into anything before I up the hash.

@alyssawilk
Copy link

Awesome, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants