Skip to content
This repository was archived by the owner on Jul 12, 2024. It is now read-only.

Replace Heroku with something else (GitHub Actions?) #125

Closed
pllim opened this issue Nov 16, 2020 · 2 comments
Closed

Replace Heroku with something else (GitHub Actions?) #125

pllim opened this issue Nov 16, 2020 · 2 comments

Comments

@pllim
Copy link
Member

pllim commented Nov 16, 2020

Reasons:

  • Heroku + GitHub API been flaky lately.
  • Heroku logs hard to decipher.
  • Heroku access is a bottleneck and extra maintenance burden.
  • Updating upstream dependency on Heroku can be tricky because it is cached.

This issue supersedes #122 .

Replacements that are already deployed in astropy

Replacements that work but not deployed

Replacements that need upstream fixes

No longer relevant

@pllim
Copy link
Member Author

pllim commented Nov 18, 2020

I took a stab at replacing the milestone check with custom GitHub Action but it is blocked by https://github.community/t/feature-request-add-milestone-changes-as-activity-type-to-pull-request/16778/7 .

From that exercise, my conclusions are as follow: It will be pretty much a complete refactoring moving from astropy-bot to Actions. A lot of the things that make sense now won't make sense in Actions. For example, we don't need TOML config because you can customize the Actions itself. We can use PyGithub instead of custom GitHub API, probably no need for Flask app too, etc etc.

Also not sure how to write unit tests for a custom GitHub Action.

UPDATE: Going the GitHub Action route, implementing it in TypeScript would be much more efficient. Using Python + Docker has at least a 20s overhead and that is using a custom Docker image stored at quay.io with dependencies installed.

@pllim
Copy link
Member Author

pllim commented Nov 22, 2020

Priorities...

Screenshot 2020-11-21 203607

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant