-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.7.0 was deleted #422
Comments
Looks like the intention was to remove the oracle jdk feature by rolling back 3.7.0. Would have been great to roll forward to 4.0.0 instead since the removal is a breaking change. For now I think the best way forward is to fix broken builds by re-releasing 3.7.0 to HEAD or to at least 3.6.0 - if that's to be considered a stable version. |
That would be fantastic, we have a lot of repositories to modify and rebuild if we can't get that release back :) |
With the presence of tools like Dependabot and Renovate hundreds of repositories migrated and are now broken: https://github.com/search?q=%22actions%2Fsetup-java%40v3.7.0%22&type=code |
The version `v3.7.0` of actions/setup-java was removed. Fix the workflows by using the previous version. See actions/setup-java#422.
This reverts commit 5afa7e1. The 3.7.0 release got deleted, for context see actions/setup-java#422.
This reverts commit 5afa7e1. Tag v3.7.0 was deleted; see actions/setup-java#422 for details.
589: fix(ci): Switch back to actions/[email protected] r=remcowesterhoud a=saig0 ## Description The version `v3.7.0` of actions/setup-java was removed. Fix the workflows by using the previous version. See actions/setup-java#422. ## Related issues Failed action: https://github.com/camunda/zeebe-process-test/actions/runs/3626043207 <!-- Cut-off marker _All lines under and including the cut-off marker will be removed from the merge commit message_ ## Definition of Ready Please check the items that apply, before requesting a review. You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda-cloud/zeebe/wiki/Pull-Requests-and-Code-Reviews). * [ ] I've reviewed my own code * [ ] I've written a clear changelist description * [ ] I've narrowly scoped my changes * [ ] I've separated structural from behavioural changes --> ## Definition of Done <!-- Please check the items that apply, before merging or (if possible) before requesting a review. --> _Not all items need to be done depending on the issue and the pull request._ Code changes: * [ ] The changes are backwards compatibility with previous versions * [ ] If it fixes a bug then PRs are created to backport the fix Testing: * [ ] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually Documentation: * [ ] Javadoc has been written * [ ] The documentation is updated Co-authored-by: Philipp Ossler <[email protected]>
Please just tag 3.6.0 also as 3.7.0 (or 3.7.1 / 3.8.0) to fix the majority of problems. All our actions were updated automatically and it would cost much time to downgrade them manually. |
Release 3.7.0 was deleted by the maintainers: actions/setup-java#422
Wow, this destroyed dozens of my pipelines. Please, please, never delete releases anymore 🙏 |
It's worrying that this is possible. 3.7.0 could be re-released with any code at all - if they had been malicious this could have happened quickly after most of us had auto-upgraded and it would have slipped through without anyone noticing |
Just to be certain: That is a GitHub Actions design decision and not an issue of the setup-java maintainers. This can happen with any action you use. If that is of concern you should switch to using the commit id of the action. |
This can happen but should not. Retracting released software (except in case of extreme security concerns, in which case I'd expect a notification and explanation) is a bad practice that disrupts your clients. Some software repos forbid it altogether (Maven Central), and others have a more flexible policy (NPM), but all of them state the criterion and allow others to adapt. |
`[email protected]` was deleted by the maintainers, see actions/setup-java#422 We use basic functions of `setup-java` so we can use a major version only to avoid such problems and multiple dependabot PRs
Approx. 15 minutes ago a new version 3.8.0 was released 😃 |
I guess we are updating a few dozen repositories this morning 🥲 ... |
It happened to all of the Apache Commons repositories, not fun. |
Ref: 7e48905 Release 3.7.0 was deleted (actions/setup-java#422)
Ref: f106f51 Release 3.7.0 was deleted (actions/setup-java#422)
Hello everyone. As you all are probably aware, the legal points of OracleJdk still need to be tackled and we had to delete this release of the new distribution. I would like to apologize for the inconvenience it has introduced to many of our customers, and we will do our best to prevent similar incidents from happening in the future. Thank you for understanding the situation, I will close this issue for now. |
Hello everyone. We had discussions with Oracle teams and confirmed that we can add support for Oracle OpenJDK. We've released a new version of the action with support of Oracle OpenJDK. We are sorry for the confusion. |
We have just moved all of our builds to
actions/[email protected]
and it just disappeared so they are all failing.Do we need to revert everything back to
actions/[email protected]
or is this going to be replaced?Thanks.
The text was updated successfully, but these errors were encountered: