Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.7.0 was deleted #422

Closed
fgarsombke opened this issue Dec 5, 2022 · 13 comments
Closed

Release 3.7.0 was deleted #422

fgarsombke opened this issue Dec 5, 2022 · 13 comments
Labels
bug Something isn't working

Comments

@fgarsombke
Copy link

We have just moved all of our builds to actions/[email protected] and it just disappeared so they are all failing.

Do we need to revert everything back to actions/[email protected] or is this going to be replaced?

Thanks.

@ArloL
Copy link

ArloL commented Dec 5, 2022

Looks like the intention was to remove the oracle jdk feature by rolling back 3.7.0. Would have been great to roll forward to 4.0.0 instead since the removal is a breaking change.

For now I think the best way forward is to fix broken builds by re-releasing 3.7.0 to HEAD or to at least 3.6.0 - if that's to be considered a stable version.

@fgarsombke
Copy link
Author

That would be fantastic, we have a lot of repositories to modify and rebuild if we can't get that release back :)

@JakeWharton
Copy link

With the presence of tools like Dependabot and Renovate hundreds of repositories migrated and are now broken: https://github.com/search?q=%22actions%2Fsetup-java%40v3.7.0%22&type=code

nothub added a commit to nothub/AoC2022 that referenced this issue Dec 5, 2022
saig0 added a commit to camunda/zeebe-process-test that referenced this issue Dec 6, 2022
The version `v3.7.0` of actions/setup-java was removed. Fix the workflows by using the previous version. See actions/setup-java#422.
rickie added a commit to PicnicSupermarket/error-prone-support that referenced this issue Dec 6, 2022
This reverts commit 5afa7e1. The 3.7.0
release got deleted, for context see
 actions/setup-java#422.
rickie added a commit to PicnicSupermarket/error-prone-support that referenced this issue Dec 6, 2022
This reverts commit 5afa7e1. Tag v3.7.0 was
deleted; see actions/setup-java#422 for details.
ghost pushed a commit to camunda/zeebe-process-test that referenced this issue Dec 6, 2022
589: fix(ci): Switch back to actions/[email protected] r=remcowesterhoud a=saig0

## Description

The version `v3.7.0` of actions/setup-java was removed. Fix the workflows by using the previous version. See actions/setup-java#422.

## Related issues

Failed action: https://github.com/camunda/zeebe-process-test/actions/runs/3626043207

<!-- Cut-off marker
_All lines under and including the cut-off marker will be removed from the merge commit message_

## Definition of Ready

Please check the items that apply, before requesting a review.

You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda-cloud/zeebe/wiki/Pull-Requests-and-Code-Reviews).

* [ ] I've reviewed my own code
* [ ] I've written a clear changelist description
* [ ] I've narrowly scoped my changes
* [ ] I've separated structural from behavioural changes
-->

## Definition of Done

<!-- Please check the items that apply, before merging or (if possible) before requesting a review. -->

_Not all items need to be done depending on the issue and the pull request._

Code changes:
* [ ] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to backport the fix

Testing:
* [ ] There are unit/integration tests that verify all acceptance criterias of the issue
* [ ] New tests are written to ensure backwards compatibility with further versions
* [ ] The behavior is tested manually

Documentation:
* [ ] Javadoc has been written
* [ ] The documentation is updated


Co-authored-by: Philipp Ossler <[email protected]>
@PatrickGotthard
Copy link

PatrickGotthard commented Dec 6, 2022

Please just tag 3.6.0 also as 3.7.0 (or 3.7.1 / 3.8.0) to fix the majority of problems. All our actions were updated automatically and it would cost much time to downgrade them manually.

ldziedziul added a commit to ldziedziul/hazelcast-hibernate that referenced this issue Dec 6, 2022
Release 3.7.0 was deleted by the maintainers: actions/setup-java#422
@DanySK
Copy link

DanySK commented Dec 6, 2022

Wow, this destroyed dozens of my pipelines. Please, please, never delete releases anymore 🙏

@jdrphillips
Copy link

It's worrying that this is possible. 3.7.0 could be re-released with any code at all - if they had been malicious this could have happened quickly after most of us had auto-upgraded and it would have slipped through without anyone noticing

@ArloL
Copy link

ArloL commented Dec 6, 2022

It's worrying that this is possible.

Just to be certain: That is a GitHub Actions design decision and not an issue of the setup-java maintainers. This can happen with any action you use. If that is of concern you should switch to using the commit id of the action.

@DanySK
Copy link

DanySK commented Dec 6, 2022

Just to be certain: That is a GitHub Actions design decision and not an issue of the setup-java maintainers. This can happen with any action you use. If that is of concern you should switch to using the commit id of the action.

This can happen but should not. Retracting released software (except in case of extreme security concerns, in which case I'd expect a notification and explanation) is a bad practice that disrupts your clients. Some software repos forbid it altogether (Maven Central), and others have a more flexible policy (NPM), but all of them state the criterion and allow others to adapt.
Retracting versions just because it is as simple as deleting a git tag is not a great move, IMHO. As others suggested already, in case of mistakes it would be much better to release a patch.

ldziedziul added a commit to hazelcast/hazelcast-hibernate that referenced this issue Dec 6, 2022
`[email protected]` was deleted by the maintainers, see
actions/setup-java#422

We use basic functions of `setup-java` so we can use a major version
only to avoid such problems and multiple dependabot PRs
@Gakk
Copy link

Gakk commented Dec 6, 2022

Approx. 15 minutes ago a new version 3.8.0 was released 😃

@fgarsombke
Copy link
Author

I guess we are updating a few dozen repositories this morning 🥲 ...

@garydgregory
Copy link

It happened to all of the Apache Commons repositories, not fun.

ParanoidUser added a commit to ParanoidUser/codewars-handbook that referenced this issue Dec 13, 2022
ParanoidUser added a commit to ParanoidUser/toolbox-opdf that referenced this issue Dec 13, 2022
@panticmilos
Copy link
Contributor

Hello everyone. As you all are probably aware, the legal points of OracleJdk still need to be tackled and we had to delete this release of the new distribution. I would like to apologize for the inconvenience it has introduced to many of our customers, and we will do our best to prevent similar incidents from happening in the future.

Thank you for understanding the situation, I will close this issue for now.

@dmitry-shibanov
Copy link
Contributor

Hello everyone. We had discussions with Oracle teams and confirmed that we can add support for Oracle OpenJDK. We've released a new version of the action with support of Oracle OpenJDK. We are sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants