Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-renderer): Release on the JS publication on Maven Central #1751

Merged
merged 2 commits into from
Dec 6, 2022
Merged

feat(web-renderer): Release on the JS publication on Maven Central #1751

merged 2 commits into from
Dec 6, 2022

Conversation

DanySK
Copy link
Member

@DanySK DanySK commented Dec 5, 2022

No description provided.

@DanySK
Copy link
Member Author

DanySK commented Dec 5, 2022

@AngeloFilaseta, this PR is meant to help debug why uploading the JS stuff made the release on Central fail.

@DanySK DanySK force-pushed the ci/(web-renderer)-test-JS-release-on-Maven-Central branch from 58a7112 to db5e06b Compare December 5, 2022 11:49
@codecov-commenter
Copy link

Codecov Report

Merging #1751 (db5e06b) into master (f8362a3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1751   +/-   ##
=========================================
  Coverage     60.76%   60.76%           
  Complexity       48       48           
=========================================
  Files             7        7           
  Lines           288      288           
  Branches         47       47           
=========================================
  Hits            175      175           
  Misses           79       79           
  Partials         34       34

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DanySK DanySK force-pushed the ci/(web-renderer)-test-JS-release-on-Maven-Central branch from db5e06b to 88d7635 Compare December 5, 2022 13:30
@AngeloFilaseta
Copy link
Contributor

We can get rid of the implementation(project.dependencies.enforcedPlatform(libs.kotlin.wrappers.bom)) dependency from alchemist-web-renderer jsMain sourceSet. With just few changes everything works in the project and the CD should make it. The dependency can also be removed from the catalog and the yarn.lock file needs to be updated. Is it possible for me to update the current PR or do I need to create a new one?

@DanySK
Copy link
Member Author

DanySK commented Dec 5, 2022

You cannot update this PR unless I give you write access to the project/organization, which I prefer not to.

BUT you can open a PR having branch ci/(web-renderer)-test-JS-release-on-Maven-Central as base. Updates to that branch would update this PR, the execution would check that things work, and we should be good to go.

@DanySK DanySK changed the title ci(web-renderer): test JS release on Maven Central feat(web-renderer): Release on the JS publication on Maven Central Dec 5, 2022
@DanySK DanySK enabled auto-merge (squash) December 6, 2022 08:00
@DanySK
Copy link
Member Author

DanySK commented Dec 6, 2022

The failure is not ours, it is due to actions/setup-java#422. They retracted a release.

@DanySK DanySK force-pushed the ci/(web-renderer)-test-JS-release-on-Maven-Central branch from 7078366 to e629ef5 Compare December 6, 2022 09:18
@DanySK DanySK force-pushed the ci/(web-renderer)-test-JS-release-on-Maven-Central branch from e629ef5 to 6f7ddf8 Compare December 6, 2022 10:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DanySK DanySK merged commit 94148c0 into master Dec 6, 2022
@DanySK DanySK deleted the ci/(web-renderer)-test-JS-release-on-Maven-Central branch December 6, 2022 12:11
DanySK pushed a commit that referenced this pull request Dec 6, 2022
@semantic-release-bot
chore(release): 25.2.0 [skip ci]
c89bf9d 
## [25.2.0](25.1.1...25.2.0) (2022-12-06)

### Features

* **web-renderer:** Release on the JS publication on Maven Central ([#1751](#1751)) ([94148c0](94148c0))

### Build and continuous integration

* **deps:** update danysk/build-check-deploy-gradle-action action to v2.1.16 ([137e7ab](137e7ab))
* **mergify:** auto-merge working dependabot updates ([352a34a](352a34a))
* **mergify:** treat renovate and dependabot equally (auto-rebase-update + auto rebase-merge) ([5fabaeb](5fabaeb))

### Dependency updates

* **deps:** update react to v18.2.0-pre.455 ([73a8fc9](73a8fc9))
@DanySK
Copy link
Member Author

DanySK commented Dec 6, 2022

🎉 This PR is included in version 25.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@DanySK DanySK added the released label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-update-rebase released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanySK @codecov-commenter @AngeloFilaseta