fix(ci): Switch back to actions/[email protected] #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version `v3.7.0` of actions/setup-java was removed. Fix the workflows by using the previous version. See actions/setup-java#422.
remcowesterhoud
approved these changes
Dec 6, 2022
|
Build succeeded: |
ghost
merged commit 
|
It might be better to switch the version to the latest major release Note that this may result in reduced reproducibility. However, since all tags can be moved, the only way to guarantee reproducibility is by pinning specific commit shas. Likely it is easiest for us when using actions like these (e.g. checkout) to use the major version tag. |
7 tasks
ghost
pushed a commit
that referenced
this pull request
Dec 6, 2022
590: ci: use major version for actions/setup-java r=saig0 a=korthout ## Description <!-- Please explain the changes you made here. --> Changes the version used for actions/setup-java in all workflows to major version `v3`. This should reduce the amount of effort needed to update this action (i.e. no more dependabot pull requests unless a new major version is released). It should also avoid problems when actions/setup-java removes a specific patch release tag (as has happened before, see pull request mentioned below). Using a major version is possible because GH recommends moving the major release tags along with the minor and patch releases of that same version. Note that this may result in reduced reproducibility. However, since all tags can be moved, the only way to guarantee reproducibility is by pinning specific commit shas. Since we don't necessarily depend on a specific version, we should trust the maintainers of the action to adhere to semver. ## Related issues <!-- Which issues are closed by this PR or are related --> discussed in #589 (comment) <!-- Cut-off marker _All lines under and including the cut-off marker will be removed from the merge commit message_ ## Definition of Ready Please check the items that apply, before requesting a review. You can find more details about these items in our wiki page about [Pull Requests and Code Reviews](https://github.com/camunda-cloud/zeebe/wiki/Pull-Requests-and-Code-Reviews). * [ ] I've reviewed my own code * [ ] I've written a clear changelist description * [ ] I've narrowly scoped my changes * [ ] I've separated structural from behavioural changes --> ## Definition of Done <!-- Please check the items that apply, before merging or (if possible) before requesting a review. --> _Not all items need to be done depending on the issue and the pull request._ Code changes: * [ ] The changes are backwards compatibility with previous versions * [ ] If it fixes a bug then PRs are created to backport the fix Testing: * [ ] There are unit/integration tests that verify all acceptance criterias of the issue * [ ] New tests are written to ensure backwards compatibility with further versions * [ ] The behavior is tested manually Documentation: * [ ] Javadoc has been written * [ ] The documentation is updated Co-authored-by: Nico Korthout <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The version
v3.7.0of actions/setup-java was removed. Fix the workflows by using the previous version. See actions/setup-java#422.Related issues
Failed action: https://github.com/camunda/zeebe-process-test/actions/runs/3626043207
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
Testing:
Documentation: