Update the action to run on Node 16 #220
Conversation
|
Can you please prioritize this quick PR? These deprecated warning messages are clogging up our CI. |
|
ye, if we could get quickie mergies that'd be vewy much apweciated uwu 🥺🙏 |
|
cc: @svartalf can you look into this when you get some time? These deprecation warnings/alerts congest thousand of CI/CD workflows... Thanks a lot for your time! |
|
I would argue that this is why we need repos like this to be run as DAOs. Advantage for stakeholders: They can get commits merged when a maintainer goes on holiday, even for very small one-maintainer projects. Advantage for maintainers: They can ask for a salary in exchange for their efforts. The DAO acts like a mini lightweight company with shareholders. Anyway, muse over. I don't want to sell you anything! :-) |
Includes the following new unmerged PRs: - <actions-rs/toolchain#220> "Update the action to run on Node 16" - <actions-rs/toolchain#222> "chore: bump @actions deps" Addresses the "Node.js 12 actions are deprecated" and "`set-output` command is deprecated" warnings.
|
Can you please prioritize this quick PR? |
|
Could someone explain why this pull request hasn't been merged yet? |
Because this repo/action has been abandoned for a long time now. I suggest to use https://github.com/dtolnay/rust-toolchain instead. |
The former generates tons of warnings runs on deprecated subcomponents and appears to be unmaintained. References: * https://www.reddit.com/r/rust/comments/vyx4oj/actionsrs_organization_became_unmaintained/ * actions-rs/toolchain#216 * actions-rs/toolchain#220 * rust-lang/hashbrown#467 (and many others doing this)
This PR supersedes actions-rs#220 and actions-rs#222 by applying both fixes at once Fixes actions-rs#219 Fixes actions-rs#221 You can now use this action (and cargo) without deprecations by using a workflow similar to this: on: [push] name: build jobs: check: name: Rust project runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - name: Install latest nightly uses: ThexXTURBOXx/toolchain@master with: toolchain: nightly override: true components: rustfmt, clippy # `cargo check` command here will use installed `nightly` # as it is set as an "override" for current directory - name: Run cargo check uses: richb-hanover/cargo@master with: command: check
Node 12 is deprecated per https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Fix #219