Update translate workflow #4027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hankolsen
force-pushed
the
update-translate-workflow
branch
from
1067909 to
20b7543
Compare
Update to latest master
hankolsen
force-pushed
the
update-translate-workflow
branch
from
20b7543 to
eedc4eb
Compare
hankolsen
force-pushed
the
update-translate-workflow
branch
from
eedc4eb to
93ca305
Compare
hankolsen
commented
Nov 7, 2022
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
.github/workflows/translations.yml line 39 at r1 (raw file):
- name: Install nightly Rust run: curl https://sh.rustup.rs -sSf | sh -s -- -y
Antoher alternative could be to use https://github.com/dtolnay/rust-toolchain
hankolsen
commented
Nov 7, 2022
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
.github/workflows/translations.yml line 39 at r1 (raw file):
Previously, hankolsen wrote…
Antoher alternative could be to use https://github.com/dtolnay/rust-toolchain
Original idea came from: actions-rs/toolchain#219 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates actions used in the translations.yml workflow.
Github will start running all actions on Node 16, so actions using Node 12 need to be update to use Node 16.
This PR updates:
Remove the action actions-rs/toolchain as it has been abandoned. Install Rust "manually" instead.
This change is