Lupl/ungrouped pagination #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redesign introduces major class API changes: 1. Initialization now takes the endpoint, query and model class directly, this simplifies class usage and allows for better state retention in the instance. 2. functionality previously defined in SPARQLModelAdapter.__call__ is transposed to SPARQLModelAdapter.query which doesn't take any arguments but uses instance state to run a query against an endpoint. Considering planned grouping and pagination functionality, responsibilites should be split into multiple specialized methods Concerns: #38.
Adapt basic SPARQLModelAdapter test according to redesigned SPARQLModelAdapter interface. Concerns: #38
SPARQLModelAdapter.query_group_by allows to group model instances retrevied from a query by a SPARQL binding. Grouping must be possible based on SPARQL bindings, this is why coupling the constructed model instance with the SPARQL bindings in SPARQLModelAdapter.query is important. Also introduce a custom KeyError for indicating that a requested binding is not available in the SPARQL projection for more specific testing. Closes #40.
Implement basic tests including basic failure tests for SPARQLModelAdapter.query_group_by. Also introduce a testing utils section including a module for Hypothesis strategies. Note: Care must be taken when using Hypothesis with tests that target a remote service since Hypothesis generates input and runs a single test many times which can lead to timeouts.
temporary_query_overrides allows to temporarily override the queryString attribute in a SPARQLWrapper object. The initial query is cached and returned on exit.
Implement SPARQLModelAdapter.query_paginate for ungrouped pagination. For ungrouped pagination the internal query is temporarily modified with page/offset and size/limit according to the page and size parameters. For FastAPI and pagination see https://lewoudar.medium.com/fastapi-and-pagination-d27ad52983a. Closes #43.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43