-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider redesign of SPARQLModelAdapter #38
Labels
enhancement
New feature or request
Comments
lu-pl
added a commit
that referenced
this issue
Aug 4, 2024
The redesign introduces major class API changes: 1. Initialization now takes the endpoint, query and model class directly, this simplifies class usage and allows for better state retention in the instance. 2. functionality previously defined in SPARQLModelAdapter.__call__ is transposed to SPARQLModelAdapter.query which doesn't take any arguments but uses instance state to run a query against an endpoint. Considering planned grouping and pagination functionality, responsibilites should be split into multiple specialized methods Concerns: #38.
lu-pl
added a commit
that referenced
this issue
Aug 4, 2024
Adapt basic SPARQLModelAdapter test according to redesigned SPARQLModelAdapter interface. Concerns: #38
Closed
lu-pl
added a commit
that referenced
this issue
Aug 4, 2024
The redesign introduces major class API changes: 1. Initialization now takes the endpoint, query and model class directly, this simplifies class usage and allows for better state retention in the instance. 2. functionality previously defined in SPARQLModelAdapter.__call__ is transposed to SPARQLModelAdapter.query which doesn't take any arguments but uses instance state to run a query against an endpoint. Considering planned grouping and pagination functionality, responsibilites should be split into multiple specialized methods Concerns: #38.
lu-pl
added a commit
that referenced
this issue
Aug 4, 2024
Adapt basic SPARQLModelAdapter test according to redesigned SPARQLModelAdapter interface. Concerns: #38
lu-pl
added a commit
that referenced
this issue
Aug 4, 2024
Adapt basic SPARQLModelAdapter test according to redesigned SPARQLModelAdapter interface. Concerns: #38
lu-pl
added a commit
that referenced
this issue
Aug 20, 2024
The redesign introduces major class API changes: 1. Initialization now takes the endpoint, query and model class directly, this simplifies class usage and allows for better state retention in the instance. 2. functionality previously defined in SPARQLModelAdapter.__call__ is transposed to SPARQLModelAdapter.query. Closes: #38.
Merged
lu-pl
added a commit
that referenced
this issue
Aug 20, 2024
The redesign introduces major class API changes: 1. Initialization now takes the endpoint, query and model class directly, this simplifies class usage and allows for better state retention in the instance. 2. functionality previously defined in SPARQLModelAdapter.__call__ is transposed to SPARQLModelAdapter.query. Closes: #38.
lu-pl
added a commit
that referenced
this issue
Aug 20, 2024
The redesign introduces major class API changes: 1. Initialization now takes the endpoint, query and model class directly, this simplifies class usage and allows for better state retention in the instance. 2. functionality previously defined in SPARQLModelAdapter.__call__ is transposed to SPARQLModelAdapter.query. Closes: #38.
lu-pl
added a commit
that referenced
this issue
Aug 20, 2024
The redesign introduces major class API changes: 1. Initialization now takes the endpoint, query and model class directly, this simplifies class usage and allows for better state retention in the instance. 2. functionality previously defined in SPARQLModelAdapter.__call__ is transposed to SPARQLModelAdapter.query. Closes: #38.
lu-pl
added a commit
that referenced
this issue
Aug 20, 2024
The redesign introduces major class API changes: 1. Initialization now takes the endpoint, query and model class directly, this simplifies class usage and allows for better state retention in the instance. 2. functionality previously defined in SPARQLModelAdapter.__call__ is transposed to SPARQLModelAdapter.query. Closes: #38.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
An alternative and arguably better interface for
SPARQLModelAdaper
would be something like this:This simplifies usage and splits the responsibilities of
SPARQLModelAdapter.__call__
into separate specialized methods.A first step would be to transfer
SPARQLModelAdapter.__call__
toSPARQLModelAdaper.query
.The text was updated successfully, but these errors were encountered: