Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: changed the default behaviour of strictQualifiedDateTimes fix: #845 #936

Open
wants to merge 85 commits into
base: v4.0.0
Choose a base branch
from

Conversation

Sangyog10
Copy link

@Sangyog10 Sangyog10 commented Nov 8, 2024

Closes #845

Changes

Changed the default behaviour of strictQualifiedDateTimes to true in the constructor

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

mttrbrts and others added 30 commits November 24, 2023 13:26
* feat(types): build uniontypes too

Signed-off-by: Matt Roberts <[email protected]>

* fix(build): include unions in index

Signed-off-by: Matt Roberts <[email protected]>

* chore(deps): upgrade codegen to latest release

Signed-off-by: Matt Roberts <[email protected]>

---------

Signed-off-by: Matt Roberts <[email protected]>
…#767)

* fix(parser): throw error when concept is extending itself in CTO

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

* fix(parser): throw error when concept is extending itself in JSON metamodel form

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

* fix(parser): throw error when concept is extending itself in the AST

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

* refactor(validation): alphabetical rearrangement

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

* test(self-extending): remove redundant tests (codepath covered in concerto-cto)

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

* test(fix): remove unneeded import

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>

---------

Signed-off-by: Stefan Blaginov <[email protected]>
Signed-off-by: Stefan Blaginov <[email protected]>
Co-authored-by: Stefan Blaginov <[email protected]>
…ccordproject#773)

* fix(error): adding type to error in string validator in introspect

Signed-off-by: Santanu Roy <[email protected]>
Co-authored-by: Santanu Roy <[email protected]>
…/concerto-util (accordproject#780)

chore(deps): bump follow-redirects in /packages/concerto-util

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.0 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.0...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ages/concerto-types (accordproject#783)

chore(deps-dev): bump follow-redirects in /packages/concerto-types

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/concerto-vocabulary (accordproject#782)

chore(deps): bump follow-redirects in /packages/concerto-vocabulary

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dproject/concerto-util in /packages/concerto-cto (accordproject#786)

chore(deps): bump axios, @accordproject/concerto-metamodel and @accordproject/concerto-util

Bumps [axios](https://github.com/axios/axios) to 1.6.0 and updates ancestor dependencies [axios](https://github.com/axios/axios), [@accordproject/concerto-metamodel](https://github.com/accordproject/concerto/tree/HEAD/packages/concerto-metamodel) and [@accordproject/concerto-util](https://github.com/accordproject/concerto/tree/HEAD/packages/concerto-util). These dependencies need to be updated together.


Updates `axios` from 0.23.0 to 1.6.0
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v0.23.0...v1.6.0)

Updates `@accordproject/concerto-metamodel` from 3.8.1 to 3.9.1
- [Release notes](https://github.com/accordproject/concerto/releases)
- [Commits](https://github.com/accordproject/concerto/commits/v3.9.1/packages/concerto-metamodel)

Updates `@accordproject/concerto-util` from 3.13.0 to 3.16.1
- [Release notes](https://github.com/accordproject/concerto/releases)
- [Changelog](https://github.com/accordproject/concerto/blob/main/packages/concerto-util/changelog.txt)
- [Commits](https://github.com/accordproject/concerto/commits/v3.16.1/packages/concerto-util)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
- dependency-name: "@accordproject/concerto-metamodel"
  dependency-type: direct:production
- dependency-name: "@accordproject/concerto-util"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…kages/concerto-core (accordproject#789)

chore(deps): bump axios and @accordproject/concerto-metamodel

Bumps [axios](https://github.com/axios/axios) to 1.6.7 and updates ancestor dependency [@accordproject/concerto-metamodel](https://github.com/accordproject/concerto/tree/HEAD/packages/concerto-metamodel). These dependencies need to be updated together.


Updates `axios` from 0.23.0 to 1.6.7
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v0.23.0...v1.6.7)

Updates `@accordproject/concerto-metamodel` from 3.9.0 to 3.9.1
- [Release notes](https://github.com/accordproject/concerto/releases)
- [Commits](https://github.com/accordproject/concerto/commits/v3.9.1/packages/concerto-metamodel)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
- dependency-name: "@accordproject/concerto-metamodel"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roject#790)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.2 to 1.15.5.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.2...v1.15.5)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…o-core (accordproject#792)

chore(deps-dev): bump axios in /packages/concerto-core

Bumps [axios](https://github.com/axios/axios) from 0.23.0 to 1.6.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v0.23.0...v1.6.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…le (accordproject#794)

* refactor(declarations): Move unique name check to model file.

Signed-off-by: Ertugrul Karademir <[email protected]>

* refactor(test): move validation checks for duplicate class to model file

Signed-off-by: Ertugrul Karademir <[email protected]>

* test: empty commit to trigger test

Signed-off-by: Ertugrul Karademir <[email protected]>

---------

Signed-off-by: Ertugrul Karademir <[email protected]>
refactor: don't use arrays to check uniqueness

Signed-off-by: Ertugrul Karademir <[email protected]>
accordproject#804)

* refactor: don't use arrays to check uniqueness

Signed-off-by: Ertugrul Karademir <[email protected]>

* refactor: also refactor unique property name check

Signed-off-by: Ertugrul Karademir <[email protected]>

* refactor: remove array for decorator uniqueness check

Signed-off-by: Ertugrul Karademir <[email protected]>

* refactor: remove uniqueness check from scalar declarations as well

Signed-off-by: Ertugrul Karademir <[email protected]>

---------

Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Sanket Shevkar <[email protected]>
Co-authored-by: Sanket Shevkar <[email protected]>
Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1.
- [Commits](indutny/node-ip@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roject/concerto-core in /packages/concerto-types (accordproject#809)

chore(deps): bump axios, @accordproject/concerto-codegen and @accordproject/concerto-core

Bumps [axios](https://github.com/axios/axios) to 1.6.0 and updates ancestor dependencies [axios](https://github.com/axios/axios), [@accordproject/concerto-codegen](https://github.com/accordproject/concerto-codegen/tree/HEAD/packages/concerto-codegen) and [@accordproject/concerto-core](https://github.com/accordproject/concerto/tree/HEAD/packages/concerto-cto). These dependencies need to be updated together.


Updates `axios` from 0.23.0 to 1.6.0
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v0.23.0...v1.6.0)

Updates `@accordproject/concerto-codegen` from 3.17.0 to 3.22.1
- [Release notes](https://github.com/accordproject/concerto-codegen/releases)
- [Commits](https://github.com/accordproject/concerto-codegen/commits/v3.22.1/packages/concerto-codegen)

Updates `@accordproject/concerto-core` from 3.16.1 to 3.16.5
- [Release notes](https://github.com/accordproject/concerto/releases)
- [Commits](https://github.com/accordproject/concerto/commits/v3.16.5/packages/concerto-cto)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
- dependency-name: "@accordproject/concerto-codegen"
  dependency-type: direct:development
- dependency-name: "@accordproject/concerto-core"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…o-vocabulary (accordproject#808)

chore(deps-dev): bump axios in /packages/concerto-vocabulary

Bumps [axios](https://github.com/axios/axios) from 0.23.0 to 1.6.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v0.23.0...v1.6.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oject#817)

Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.5 to 7.24.0.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.24.0/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* perf(core): avoid unnecessary re-serialisation

Signed-off-by: Matt Roberts <[email protected]>

* perf(core): avoid unnecessary re-serialisation

Signed-off-by: Matt Roberts <[email protected]>

---------

Signed-off-by: Matt Roberts <[email protected]>
…/concerto-cto (accordproject#821)

chore(deps): bump follow-redirects in /packages/concerto-cto

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/concerto-core (accordproject#825)

chore(deps): bump follow-redirects in /packages/concerto-core

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roject#826)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
salujajaskeerat and others added 25 commits August 27, 2024 14:47
* feat(alias-import): added test case for introspector

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(alias import):Pr fix

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(alias import):Pr fixes

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(alias import): Pr changes

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(import alias): Field renamed

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(alias-import): additional check to verify alias import

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(alias-import): Types updated

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(alias-import): reverting change-log file

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

---------

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Co-authored-by: Jaskeerat Singh Saluja <[email protected]>
…ject#894)

* feat(import-alias):patch change for aliased imported types

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(alias-import): Test cases added

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(import-alias):Test cases fixed

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(import-alias): Changelog updated

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(alias-import): ENV IMPORT_ALIASING added

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(alias-import): PR suggestions

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

* feat(alias-import): Pr suggestions

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>

---------

Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Co-authored-by: Jaskeerat Singh Saluja <[email protected]>
…erto-core (accordproject#895)

chore(deps-dev): bump webpack in /packages/concerto-core

Bumps [webpack](https://github.com/webpack/webpack) from 5.76.0 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.76.0...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rto-util (accordproject#893)

chore(deps-dev): bump elliptic in /packages/concerto-util

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.4 to 6.5.7.
- [Commits](indutny/elliptic@v6.5.4...v6.5.7)

---
updated-dependencies:
- dependency-name: elliptic
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8.
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.5...4.0.8)

---
updated-dependencies:
- dependency-name: micromatch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) from 1.6.8 to 1.7.4.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.6.8...v1.7.4)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…erto-util (accordproject#897)

chore(deps-dev): bump webpack in /packages/concerto-util

Bumps [webpack](https://github.com/webpack/webpack) from 5.79.0 to 5.94.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.79.0...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rto-core (accordproject#898)

chore(deps-dev): bump elliptic in /packages/concerto-core

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.4 to 6.5.7.
- [Commits](indutny/elliptic@v6.5.4...v6.5.7)

---
updated-dependencies:
- dependency-name: elliptic
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(decorator): validate type references
* chore(deps): update concerto-metamodel to 3.10.1
* chore(npm): move to npm workspaces
* chore(concerto-util): remove axios and colors
* chore(deps): update concerto deps

Signed-off-by: Moh <[email protected]>

* chore(deps): update concerto deps

Signed-off-by: Moh <[email protected]>

* empty

Signed-off-by: Moh <[email protected]>

---------

Signed-off-by: Moh <[email protected]>
* feat(decorators): validate decorators against model

Signed-off-by: Dan Selman <[email protected]>
Signed-off-by: Dan Selman <[email protected]>
Signed-off-by: Dan Selman <[email protected]>
* chore(jest): update version
* miscellaneous other fixes for tests

---------

Signed-off-by: Dan Selman <[email protected]>
…rdproject#932)

* chore(versions): use latest versions of other concerto packages

Signed-off-by: Jamie Shorten <[email protected]>

* chore: update package

Signed-off-by: Jamie Shorten <[email protected]>

* chore: package updates

Signed-off-by: Jamie Shorten <[email protected]>

* chore: update metamodel

Signed-off-by: Jamie Shorten <[email protected]>

* chore: fix packa lock

Signed-off-by: Jamie Shorten <[email protected]>

---------

Signed-off-by: Jamie Shorten <[email protected]>
Signed-off-by: Sangyog Puri <[email protected]>
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open this against the v4 branch as mentioned in the issue?

@Sangyog10 Sangyog10 changed the base branch from main to v4.0.0 November 13, 2024 02:33
@Sangyog10 Sangyog10 requested a review from DianaLease November 13, 2024 02:37
Copy link
Contributor

github-actions bot commented Dec 6, 2024

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make serializer option strictQualifiedDateTimes default behaviour