Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): avoid unnecessary re-serialisation #828

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

mttrbrts
Copy link
Member

@mttrbrts mttrbrts commented Mar 21, 2024

Serialization to JSON is costly (especially for large models). This change removes a redundant serialization step in the validateMetaModel function. The tests don't rely on this behaviour and the signature is unchanged. All validation happens in the deserialization step.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@mttrbrts mttrbrts marked this pull request as ready for review March 21, 2024 13:14
@mttrbrts mttrbrts requested a review from a team March 21, 2024 13:14
@mttrbrts mttrbrts merged commit e05ea3d into accordproject:main Mar 21, 2024
11 checks passed
@mttrbrts mttrbrts deleted the mr-validateMetamodel-perf branch March 21, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants