-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alias-import): added test case for introspector #882
feat(alias-import): added test case for introspector #882
Conversation
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Couple of small changes.
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
@dselman your comments have been addressed and since this is a dependency on other work for aliasing, and you are on leave, I'll dismiss the review on paper and merge the MR. Apologies for that. |
The MR is blocking other work and Dan is on leave. Dan's remarks have been addressed.
Closes #867 #878
Changes
Related Issues
Author Checklist
--signoff
option of git commit.main
fromfork:branchname