German translations need cleanup #13864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…). I suggest removing de-DE altogether to avoid future confusion
consolidate german language files
consolidated language files 'de-DE' into 'de' and removed 'de-DE'
NecatiMeral
reviewed
Aug 30, 2022
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
berkansasmaz
approved these changes
Nov 7, 2022
berkansasmaz
requested review from
berkansasmaz
and removed request for
NecatiMeral
|
Thanks for this great PR. |
berkansasmaz
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
German translations are confusing in abp. This PR aims to clean them up and avoid duplications in future.
Most modules currently contain resource files for cultures 'de' and 'de-DE'. This is an uneccessary duplication, as texts for Germany (de-DE) and Switzerland (de-CH) are essentially the same - the cultures only differ in currency symbol and decimal separators.
This existence of two almost identical files has lead to people maintaining the wrong files (mostly 'de-DE') and leaving the common language files 'de' in a out-of-date, incomplete state.
I have therefore consolidated contents of 'de-DE' into 'de' and removed 'de-DE' throughout the modules.
The same flaw, btw, exists for English language. Most modules contain 'en' and 'en-GB', which creates similar confusion, duplication and out-of-date files. I strongly suggest cleaning that up, too.