-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #69
Merged
Merged
Fixes #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This was referenced Oct 4, 2024
NamadaApp::sign_masp_spends
sometimes returns Ledger | App Error: | 28417 apdu sign verify error
#76
Closed
abenso
approved these changes
Oct 8, 2024
emmanuelm41
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few comments. I did my best to review the code using the knowledge I have about namada. Just wonder if it is correct the zemu snapshots are so different.
emmanuelm41
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes Incorrect spend authorization signatures returned by hardware wallet #70 Missing handling for dummy output notes #72 Calling
NamadaApp::sign
afterNamadaApp::get_signature
yields0: Ledger | App Error: | 27012 apdu parameters invalid
#74NamadaApp::sign_masp_spends
sometimes returnsLedger | App Error: | 28417 apdu sign verify error
#76 CallingNamadaApp::sign
in new session returnsLedger | App Error: | 27012 apdu parameters invalid
#78 Ledger | App Error: | 28417 apdu sign verify error #66