Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #69

Merged
merged 15 commits into from
Oct 8, 2024
Merged

Fixes #69

merged 15 commits into from
Oct 8, 2024

Conversation

@chcmedeiros chcmedeiros changed the base branch from main to dev September 30, 2024 12:41
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few comments. I did my best to review the code using the knowledge I have about namada. Just wonder if it is correct the zemu snapshots are so different.

app/src/crypto.c Show resolved Hide resolved
app/src/crypto.c Outdated Show resolved Hide resolved
app/src/nvdata.c Show resolved Hide resolved
app/src/parser_impl_masp.c Show resolved Hide resolved
@chcmedeiros chcmedeiros requested a review from abenso October 8, 2024 13:09
@chcmedeiros chcmedeiros merged commit 8586f79 into dev Oct 8, 2024
26 checks passed
@chcmedeiros chcmedeiros deleted the fixes branch October 8, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants