Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect spend authorization signatures returned by hardware wallet #70

Closed
murisi opened this issue Sep 24, 2024 · 1 comment
Closed

Comments

@murisi
Copy link
Contributor

murisi commented Sep 24, 2024

The call get_spend_signature() returns incorrect spend signatures when the number of generated spend randomness parameters (equal to the number of calls to get_spend_randomness()) exceeds the number of spend descriptions (equal to the number of spend authorization signatures pushed). It seems that this is due to how the hardware wallet internally indexes the spend authorization signatures it is fetching here:

const uint8_t index = transaction_header.spendlist_len - transaction_header.spends_sign_index;
.

@ainhoa-a
Copy link
Member

ainhoa-a commented Oct 4, 2024

Can be closed once #69 gets merged

@chcmedeiros chcmedeiros mentioned this issue Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants