Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing handling for dummy output notes #72

Closed
murisi opened this issue Sep 24, 2024 · 1 comment
Closed

Missing handling for dummy output notes #72

murisi opened this issue Sep 24, 2024 · 1 comment

Comments

@murisi
Copy link
Contributor

murisi commented Sep 24, 2024

The namadac client sometimes creates dummy output notes/output descriptions in order to disassociate the number of output descriptions in a Transaction from the actual number shielded outputs. These output descriptions do not correspond to any output descriptor information objects in the builder, their value is 0, and their asset type pre-encoding is dummy. The cryptographic checks should support the presence of these.

See attached a test vector containing a dummy note: dummy_note_testvector.txt . Note that there is are two output descriptions even though there is only one output description information object. Also note that most of the randomness parameters are not used. See also the code that creates them here: https://github.com/anoma/masp/blob/8d83b172698098fba393006016072bc201ed9ab7/masp_primitives/src/transaction/components/sapling/builder.rs#L1055-L1090 for how namadac constructs these output descriptions.

@ainhoa-a
Copy link
Member

ainhoa-a commented Oct 4, 2024

Can be closed once #69 gets merged

@chcmedeiros chcmedeiros mentioned this issue Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants