Offline Template: Test with all themes

[ryelle]

Our supported themes are:

• CampSite 2017
• Twenty Thirteen
• Twenty Sixteen
• Twenty Seventeen
• Twenty Nineteen
• WordCamp Base

We should also test with custom CSS, and with remote CSS.

There's a note about testing with child themes, but WCs can't have child themes, so do we need to do this?

---

The rest we don't test with, but will fix issues on

• Twenty Ten
• Twenty Eleven
• Twenty Twelve
• Twenty Fourteen
• Twenty Fifteen
• WordCamp Base Redux

[westonruter]

See also GoogleChromeLabs/pwa-wp#199 where the PWA plugin could bundle offline templates for the core themes.

[ryelle]

We would still want to inject our own, so we can show the schedule and other info related to the WordCamp.

[westonruter]

Good point. At least we could share the same base, or the PWA templates could trigger an action for the WordCamp sites to inject the content. Nevertheless, the content could also be injected via script.

[westonruter]

The need to inject content into the offline template is also something that PWA plugin isn't properly facilitating. Right now there is a wp_service_worker_error_message_placeholder() function that the offline.php template is expected to include. Perhaps this function should do an action as well?

Perhaps wp.hooks could also be incorporated into the service worker to allow filtering the offline template response prior to sending to the browser, which would better enable dynamically-populating the template with content (e.g. list of pages available offline #201 (comment)): GoogleChromeLabs/pwa-wp#142

See also GoogleChromeLabs/pwa-wp#211

[ryelle]

I think the specifics would have to depend on how the the template itself works, we might still want to override the whole thing. For more "average user" cases, an action before & after wp_service_worker_error_message_placeholder sounds good (as does the wp.hooks suggestion, though I personally haven't used it as much).