Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle offline templates for each core theme #199

Closed
westonruter opened this issue Jul 24, 2019 · 0 comments · Fixed by #225
Closed

Bundle offline templates for each core theme #199

westonruter opened this issue Jul 24, 2019 · 0 comments · Fixed by #225
Labels
service-workers
Milestone
0.4

Comments

@westonruter
Copy link
Collaborator

To support a themed offline page when using a core theme without necessitating the creation of a child theme, the PWA plugin should bundle offline page templates for each core theme.

The method for bundling can be to use template_include filter to inject the plugin path. See https://gist.github.com/westonruter/900611f075374c5468ea492f23ad4810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
service-workers
Projects
None yet
Milestone
0.4
Development

Successfully merging a pull request may close this issue.

Add offline templates for bundled core themes GoogleChromeLabs/pwa-wp
1 participant
@westonruter