Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWA error template #357

Closed
laurelfulford opened this issue Sep 2, 2019 · 3 comments · Fixed by #523
Closed

Add PWA error template #357

laurelfulford opened this issue Sep 2, 2019 · 3 comments · Fixed by #523
Labels
[Type] Enhancement Improved behavior or functionality

Comments

@laurelfulford
Copy link
Contributor

The theme needs a customized PWA error template, it needs to be helpful and fallback gracefully.

So we need to figure out:

  • What it should have; what would be really helpful
  • How best to carry over the current site's customizations
@laurelfulford laurelfulford added the [Type] Enhancement Improved behavior or functionality label Sep 2, 2019
@westonruter
Copy link
Contributor

I just tried turning off my network connection and going to a subsequent page on elsoberano.org, and I saw this:

image

This could rather display the theme's own design and custom offline content if it included an offline.php template. This was done for the WCEU site last year, with the offline template including the conference schedule.

Since it is an AMP-first site it is simpler to implement this since there is no need to worry about ensuring theme scripts and stylesheets are added to the precache.

Eventually, the offline template should include a list of the URLs that are available offline. See also:

@claudiulodro
Copy link
Contributor

I have a (non-public) note about the offline.php template at https://github.com/Automattic/newspack-issues/issues/7. @westonruter my notes say that you may be working on a version of the offline template in the PWA plugin that lists the available offline pages the user can read. Is this still something you're planning on, and do you think it'll be sometime soon? If so, I think we'd definitely want to incorporate that feature into our own offline.php template.

@westonruter
Copy link
Contributor

It's something that's been on my todo list for awhile, but I'm not going to get to it until after WCUS at the earliest. It may be December. In any case, incorporating that feature into any theme's existing offline.php template should be straightforward when it's available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improved behavior or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants